Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] Bump jna to 5.8.0 to work on M1 macs #26180

Merged
merged 1 commit into from Jun 29, 2022

Conversation

simon-mo
Copy link
Contributor

Why are these changes needed?

Otherwise running Ray will lead to the following error

(pid=54374) 2022-06-28 19:57:15,470 ERROR DefaultRayRuntimeFactory [main]: Uncaught worker exception in thread Thread[main,5,main]
(pid=54374) java.lang.UnsatisfiedLinkError: Can't load library: /Users/xmo/Library/Caches/JNA/temp/jna2533571673019432648.tmp
(pid=54374)     at java.lang.ClassLoader.loadLibrary(ClassLoader.java:2398) ~[?:?]
(pid=54374)     at java.lang.Runtime.load0(Runtime.java:785) ~[?:?]
(pid=54374)     at java.lang.System.load(System.java:1979) ~[?:?]
(pid=54374)     at com.sun.jna.Native.loadNativeDispatchLibraryFromClasspath(Native.java:1018) ~[ray_dist.jar:?]
(pid=54374)     at com.sun.jna.Native.loadNativeDispatchLibrary(Native.java:988) ~[ray_dist.jar:?]
(pid=54374)     at com.sun.jna.Native.<clinit>(Native.java:195) ~[ray_dist.jar:?]
(pid=54374)     at com.sun.jna.NativeLibrary.<clinit>(NativeLibrary.java:87) ~[ray_dist.jar:?]
(pid=54374)     at io.ray.runtime.util.JniUtils.loadLibrary(JniUtils.java:72) ~[ray_dist.jar:?]
(pid=54374)     at io.ray.runtime.RayNativeRuntime.start(RayNativeRuntime.java:93) ~[ray_dist.jar:?]
(pid=54374)     at io.ray.runtime.DefaultRayRuntimeFactory.createRayRuntime(DefaultRayRuntimeFactory.java:35) ~[ray_dist.jar:?]
(pid=54374)     at io.ray.api.Ray.init(Ray.java:32) ~[ray_dist.jar:?]
(pid=54374)     at io.ray.api.Ray.init(Ray.java:19) ~[ray_dist.jar:?]
(pid=54374)     at io.ray.runtime.runner.worker.DefaultWorker.main(DefaultWorker.java:14) ~[ray_dist.jar:?]

And looking at Philippus/sbt-dotenv#91 (comment) seems like jna upgrade solved it.

I confirmed locally on m1 macs this solved the problem indeed.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@simon-mo simon-mo merged commit 5043cc1 into ray-project:master Jun 29, 2022
edoakes pushed a commit to edoakes/ray that referenced this pull request Jul 14, 2022
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
klwuibm pushed a commit to yuanchi2807/ray that referenced this pull request Jul 27, 2022
franklsf95 pushed a commit to franklsf95/ray that referenced this pull request Aug 2, 2022
Signed-off-by: Frank Luan <lsf@berkeley.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants