Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Cloudpickle losing parents of types defined in __main__ if an ancestor used a type annotation #22553

Merged
merged 2 commits into from
Apr 4, 2022
Merged

Fix Cloudpickle losing parents of types defined in __main__ if an ancestor used a type annotation #22553

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb07395
Apply 'Incorrect pickles for subclasses of generic classes #448' from…
andenrx Mar 15, 2022
0ad4113
Merge branch 'master' into master
scv119 Apr 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion python/ray/cloudpickle/cloudpickle.py
View file
Open in desktop
Expand Up @@ -943,8 +943,12 @@ def _typevar_reduce(obj):


def _get_bases(typ):
if hasattr(typ, '__orig_bases__'):
if '__orig_bases__' in getattr(typ, '__dict__', {}):
# For generic types (see PEP 560)
# Note that simply checking `hasattr(typ, '__orig_bases__')` is not
# correct. Subclasses of a fully-parameterized generic class does not
# have `__orig_bases__` defined, but `hasattr(typ, '__orig_bases__')`
# will return True because it's defined in the base class.
bases_attr = '__orig_bases__'
else:
# For regular class objects
Expand Down