Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aiohttp 3.8.0 breaking changes (and unpin from 3.7) #20261

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion ci/asan_tests/ray-project/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
aiohttp==3.7
aiohttp
aiosignal
blist
boto3
cython==0.29.0
dataclasses; python_version < '3.7'
dm-tree==0.1.5
feather-format
flask
frozenlist
grpcio
gym
kubernetes
Expand Down
4 changes: 2 additions & 2 deletions ci/travis/test-wheels.sh
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ if [[ "$platform" == "linux" ]]; then
"$PYTHON_EXE" -u -c "import ray; print(ray.__commit__)" | grep "$TRAVIS_COMMIT" || (echo "ray.__commit__ not set properly!" && exit 1)

# Install the dependencies to run the tests.
"$PIP_CMD" install -q aiohttp==3.7 grpcio pytest==5.4.3 requests
"$PIP_CMD" install -q aiohttp aiosignal frozenlist grpcio pytest==5.4.3 requests

# Run a simple test script to make sure that the wheel works.
for SCRIPT in "${TEST_SCRIPTS[@]}"; do
Expand Down Expand Up @@ -117,7 +117,7 @@ elif [[ "$platform" == "macosx" ]]; then
"$PIP_CMD" install -q "$PYTHON_WHEEL"

# Install the dependencies to run the tests.
"$PIP_CMD" install -q aiohttp==3.7 grpcio pytest==5.4.3 requests
"$PIP_CMD" install -q aiohttp aiosignal frozenlist grpcio pytest==5.4.3 requests

# Run a simple test script to make sure that the wheel works.
for SCRIPT in "${TEST_SCRIPTS[@]}"; do
Expand Down
4 changes: 2 additions & 2 deletions dashboard/optional_deps.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@
import prometheus_client # noqa: F401

import aiohttp # noqa: F401
import aiohttp.signals
import aiosignal # noqa: F401
import aiohttp.web # noqa: F401
import aiohttp_cors # noqa: F401
from aiohttp import hdrs # noqa: F401
from aiohttp.frozenlist import FrozenList # noqa: F401
from frozenlist import FrozenList # noqa: F401
from aiohttp.typedefs import PathLike # noqa: F401
from aiohttp.web import RouteDef # noqa: F401

Expand Down
6 changes: 3 additions & 3 deletions dashboard/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@
# All third-party dependencies that are not included in the minimal Ray
# installation must be included in this file. This allows us to determine if
# the agent has the necessary dependencies to be started.
from ray.dashboard.optional_deps import (aiohttp, aioredis, hdrs, FrozenList,
PathLike, RouteDef)
from ray.dashboard.optional_deps import (aiohttp, aiosignal, aioredis, hdrs,
FrozenList, PathLike, RouteDef)

try:
create_task = asyncio.create_task
Expand Down Expand Up @@ -401,7 +401,7 @@ def freeze(cls):
sig.freeze()


class Signal(aiohttp.signals.Signal):
class Signal(aiosignal.Signal):
__slots__ = ()

def __init__(self, owner):
Expand Down
2 changes: 2 additions & 0 deletions python/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,11 @@
# setup.py install_requires
aiohttp>=3.7
aioredis < 2
aiosignal
click >= 7.0
cloudpickle
filelock
frozenlist
gpustat >= 1.0.0b1
grpcio >= 1.28.1
jsonschema
Expand Down
4 changes: 3 additions & 1 deletion python/requirements/requirements_default.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
aiohttp==3.7
aiohttp>=3.7
aiosignal
aiohttp_cors
aioredis<2
colorful
frozenlist
opencensus
prometheus_client>=0.7.1
4 changes: 3 additions & 1 deletion python/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -198,10 +198,12 @@ def get_packages(self):
"fsspec",
],
"default": [
"aiohttp == 3.7",
"aiohttp >= 3.7",
"aiosignal",
"aiohttp_cors",
"aioredis < 2",
"colorful",
"frozenlist",
"py-spy >= 0.2.0",
"requests",
"gpustat >= 1.0.0b1", # for windows
Expand Down