-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to TypeScript; Remove Dockerfile #49
Conversation
Hello and welcome to RavSam 馃挏. Thanks for opening your first pull request. We really appreciate your work for our organization. I will assign one of our team members to review your pull request. The reviewer will review your work and merge the pull request accordingly. Thanks. |
@vladkens You have really done a great job! I'll need some time to review the PR but I'll do so as quickly as possible. Once again, thank you so much for your work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- name: Package Action | ||
run: npm run package | ||
|
||
- name: Commit if dist has changed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vladkens Do you think this step makes more sense? If the dist has uncommitted changes, we can use the action to push automatically. This I think would also help in case someone forgot to package the action locally. Let me know your thoughts on this.
@ravgeetdhillon Any plans for a new release with this change? |
@ulgens Currently, I'm testing this in a private repo to make sure everything works as expected. Hopefully, I'll release a v2 this weekend. |
@ravgeetdhillon Got it, thanks a lot. |
Hi. I like your project, I use it in my actions.
But I didn't like that it required a docker build every time to work (#47). I looked that there is an open issue (#38) to rewrite the project to JavaScript using GitHub native libraries for actions (to run without docker).
I rewrote the code from Python to TypeScript, as described in the official GitHub example: https://github.com/actions/typescript-action/
I also added tests and correct readme. Checked in my actions - it works as before, only you don't have to wait 17 seconds each time for Docker to build 馃槂
I hope you will accept this PR. Good luck!