RavenDB-22279 - ClusterWideTransaction_WhenRestoreFromIncrementalBackupAfterStoreAndDelete_ShouldDeleteInTheDestination fails on sharding

[shaharhikri]

Issue link

https://issues.hibernatingrhinos.com/issue/RavenDB-22279/SlowTests.Issues.RavenDB21050.ClusterWideTransactionWhenRestoreFromIncrementalBackupAfterStoreAndDeleteShouldDeleteInTheDestinat

Additional description

SaveChanges for ClusterWideTransaction on sharded db is waiting for index notification only on the ClusterStateMachine and not on the shards, so the backup is ending before the shareds perform the cluster-wide transactions commands.
On restore, we don't need to wait because the cluster transactions are executed directly on the shards DocumentDatabase for each backup file.

Type of change

• Bug fix
• Regression bug fix
• Optimization
• New feature

How risky is the change?

• Low
• Moderate
• High
• Not relevant

Backward compatibility

• Non breaking change
• Ensured. Please explain how has it been implemented?
• Breaking change
• Not relevant

Is it platform specific issue?

• Yes. Please list the affected platforms.
• No

Documentation update

• This change requires a documentation update. Please mark the issue on YouTrack using Documentation Required tag.
• No documentation update is needed

Testing by Contributor

• Tests have been added that prove the fix is effective or that the feature works
• Internal classes added to the test class (e.g. entity or index definition classes) have the lowest possible access modifier (preferable private)
• It has been verified by manual testing

Testing by RavenDB QA team

• This change requires a special QA testing due to possible performance or resources usage implications (CPU, memory, IO). Please mark the issue on YouTrack using QA Required tag.
• No special testing by RavenDB QA team is needed

Is there any existing behavior change of other features due to this change?

• Yes. Please list the affected features/subsystems and provide appropriate explanation
• No

UI work

• It requires further work in the Studio. Please mark the issue on YouTrack using Studio Required tag.
• No UI work is needed

[karmeli87]

Please check failing tests

[karmeli87]

Sharding as well

[shaharhikri]

Done