RavenDB-22305 - Missing DirtyMemory from the memory notification

ravendb · May 16, 2024 · ba42d13 · ba42d13
1 parent 5e6d0a2
commit ba42d13
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 5 deletions.
diff --git a/src/Raven.Server/Documents/Handlers/Debugging/MemoryDebugHandler.cs b/src/Raven.Server/Documents/Handlers/Debugging/MemoryDebugHandler.cs
@@ -538,7 +538,6 @@ internal sealed class MemoryInfo
             public string EncryptionBuffersPool { get; set; }
             public string EncryptionLockedMemory { get; set; }
             public string MemoryMapped { get; set; }
-            public string ScratchDirtyMemory { get; set; }
             public bool IsHighDirty { get; set; }
             public string DirtyMemory { get; set; }
             public string AvailableMemory { get; set; }

diff --git a/src/Sparrow.Server/LowMemory/MemoryInformation.cs b/src/Sparrow.Server/LowMemory/MemoryInformation.cs
@@ -745,7 +745,7 @@ internal static DirtyMemoryState GetDirtyMemoryState()
 
             return new DirtyMemoryState
             {
-                IsHighDirty = totalScratchMemory > 
+                IsHighDirty = totalScratchMemory >
                               TotalPhysicalMemory * LowMemoryNotification.Instance.TemporaryDirtyMemoryAllowedPercentage,
                 TotalDirty = totalScratchMemory
             };

diff --git a/test/Tests.Infrastructure/TestMetrics/TestResourceSnapshotWriter.cs b/test/Tests.Infrastructure/TestMetrics/TestResourceSnapshotWriter.cs
@@ -97,7 +97,6 @@ private TestResourceSnapshot GetTestResourceSnapshot(TestStage testStage, IAssem
                 AvailableMemoryInMb = memoryInfo.AvailableMemory.GetValue(SizeUnit.Megabytes),
                 CurrentCommitChargeInMb = memoryInfo.CurrentCommitCharge.GetValue(SizeUnit.Megabytes),
                 SharedCleanMemoryInMb = memoryInfo.SharedCleanMemory.GetValue(SizeUnit.Megabytes),
-                TotalScratchDirtyMemory = MemoryInformation.GetDirtyMemoryState().TotalDirty.GetValue(SizeUnit.Megabytes),
                 CurrentIpv4Connections = tcpConnections.CurrentIpv4,
                 CurrentIpv6Connections = tcpConnections.CurrentIpv6
             };
@@ -141,8 +140,6 @@ public class TestResourceSnapshot
 
             public long SharedCleanMemoryInMb { get; set; }
 
-            public long TotalScratchDirtyMemory { get; set; }
-
             public long TotalScratchAllocatedMemory { get; set; }
 
             public long TotalDirtyMemory { get; set; }