Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves a vulnerability by upgrading rimraf to the latest version #292

Closed
wants to merge 2 commits into from

Conversation

kconvery
Copy link

@kconvery kconvery commented Jan 7, 2024

Snyk has reported a vulnerability in inflight (https://security.snyk.io/vuln/SNYK-JS-INFLIGHT-6095116) which this PR aims to resolve by upgrading the dependent package rimraf to the latest version that no longer references inflight as a transitive dependency.

kconvery and others added 2 commits January 8, 2024 10:02
resolves a vulnerabilty by upgrading rimraf to the latest version (5.…
@raszi
Copy link
Owner

raszi commented Jan 8, 2024

Thank you!

@raszi
Copy link
Owner

raszi commented Jan 8, 2024

Can we do a more conservative upgrade? Since it seems that the upgraded transient dependencies are not compatible with Node 12.

@jjshinobi
Copy link

jjshinobi commented Feb 28, 2024

Can we do a more conservative upgrade? Since it seems that the upgraded transient dependencies are not compatible with Node 12.

It is not possible. Version 3 of rimraf package is using old v7 glob which has the vulnurability. From Version 4, rimraf requires node >=14. Can we please release an upgrade of tmp package to use Node 14?

@raszi
Copy link
Owner

raszi commented Feb 28, 2024

Thank you for your changes! I needed to update the CI and bump up the minimum Node version, so I fixed this with #293.

@jjshinobi
Copy link

Thanks @raszi !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants