Merge pull request #188 from raszi/gh-187

HOTFIX #187: restore behaviour for #182
raszi · Mar 20, 2019 · 05aba23 · 05aba23
2 parents 69ad512 + 0f7a3d4
commit 05aba23
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 7 deletions.
diff --git a/README.md b/README.md
@@ -48,6 +48,15 @@ dependency to version 0.0.33.
 For node versions < 0.8 you must limit your node-tmp dependency to
 versions < 0.0.33.
 
+### Node Versions < 8.12.0
+
+The SIGINT handler will not work correctly with versions of NodeJS < 8.12.0.
+
+### Windows
+
+Signal handlers for SIGINT will not work. Pressing CTRL-C will leave behind
+temporary files and directories.
+
 ## How to install
 
 ```bash

diff --git a/lib/tmp.js b/lib/tmp.js
@@ -147,7 +147,7 @@ function _generateTmpName(opts) {
     (isBlank(opts.prefix) ? 'tmp-' : opts.prefix),
     process.pid,
     _randomChars(12),
-    (isBlank(opts.postfix) ? '' : opts.postfix)
+    (opts.postfix ? opts.postfix : '')
   ].join('');
 
   return path.join(opts.dir || tmpDir, name);
@@ -241,8 +241,6 @@ function file(options, callback) {
     opts = args[0],
     cb = args[1];
 
-  opts.postfix = isBlank(opts.postfix) ? '.tmp' : opts.postfix;
-
   // gets a temporary filename
   tmpName(opts, function _tmpNameCreated(err, name) {
     /* istanbul ignore else */
@@ -294,8 +292,6 @@ function fileSync(options) {
     args = _parseArguments(options),
     opts = args[0];
 
-  opts.postfix = isBlank(opts.postfix) ? '.tmp' : opts.postfix;
-
   const discardOrDetachDescriptor = opts.discardDescriptor || opts.detachDescriptor;
   const name = tmpNameSync(opts);
   var fd = fs.openSync(name, CREATE_FLAGS, opts.mode || FILE_MODE);

diff --git a/test/child-process.js b/test/child-process.js
@@ -82,9 +82,9 @@ function _doSpawn(commandArgs, cb, signal) {
 
   if (signal) {
     setTimeout(function () {
-      // does not work on node 6
+      // SIGINT does not work on node <8.12.0
       child.kill(signal);
-    }, 2000);
+    }, 1000);
   }
 }