Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Update latest build to build git & remove GML #2650

Merged
merged 2 commits into from Nov 14, 2022
Merged

CI: Update latest build to build git & remove GML #2650

merged 2 commits into from Nov 14, 2022

Conversation

snowman2
Copy link
Member

No description provided.

@snowman2 snowman2 changed the title CI: Update latest build to build git CI: Update latest build to build git & remove GML Nov 12, 2022
snowman2
snowman2 commented Nov 12, 2022
View reviewed changes
ci/gdal-compile.sh
@@ -22,7 +22,6 @@ cmake .. \
-DBUILD_SHARED_LIBS=ON \
-DCMAKE_BUILD_TYPE=Release \
-DOGR_BUILD_OPTIONAL_DRIVERS=OFF \
-DOGR_ENABLE_DRIVER_GML=ON \
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OSGeo/gdal#6647

@snowman2 snowman2 added the ci label Nov 12, 2022
@snowman2
Copy link
Member Author

Interesting messages that would be good to address:

SKIPPED [1] tests/test_subdatasets.py:9: GDAL not compiled with NetCDF driver.
SKIPPED [1] tests/test_dataset_rw.py:46: GDAL not compiled with GPKG driver.
SKIPPED [1] tests/test_read.py:221: HDF driver not available

@snowman2
Copy link
Member Author

snowman2 commented Nov 13, 2022 •
edited

GPKG requires libspatiallite that depends on PROJ. So, going to skip that one so we can have the latest PROJ without having to to compile it manually. The others shouldn't be too bad to add though.

@snowman2
Copy link
Member Author

Failed test: test_search_gdal_data_debian(mock_debian)

@rouault
Copy link
Contributor

rouault commented Nov 13, 2022

GPKG requires libspatiallite that depends on PROJ.

no, it doesn't. It may use libspatialite, but only libsqlite3 is required

sgillies
sgillies approved these changes Nov 13, 2022
View reviewed changes
Copy link
Member

@sgillies sgillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did GML sneak in here? 😂

@snowman2
Copy link
Member Author

GPKG requires libspatiallite that depends on PROJ.

no, it doesn't. It may use libspatialite, but only libsqlite3 is required

That was very helpful, thanks!

@snowman2
Copy link
Member Author

How did GML sneak in here? 😂

It was a workaround. With the fix for OSGeo/gdal#6647, it is no longer needed.

@snowman2 snowman2 merged commit c47bea8 into rasterio:maint-1.3 Nov 14, 2022
@snowman2 snowman2 deleted the maint-1.3 branch November 14, 2022 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgillies sgillies sgillies approved these changes

@vincentsarago vincentsarago Awaiting requested review from vincentsarago

Assignees
No one assigned
Labels
ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@snowman2 @rouault @sgillies