Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test build of 34c0dd5 #90

Merged
merged 51 commits into from
Oct 11, 2022
Merged
Show file tree
Hide file tree
Changes from 23 commits
Commits
Show all changes
51 commits
Select commit Hold shift + click to select a range
d578bb4
Test build of 34c0dd5
sgillies Sep 26, 2022
eba1d28
Set fetch depth
sgillies Sep 26, 2022
aa4e5ca
Use branch name
sgillies Sep 26, 2022
f67055d
Update vcpkg.json
sgillies Sep 26, 2022
fc7d93f
Add vcpkg.json to hash key
sgillies Sep 26, 2022
fdfc152
Update vcpkg.json
sgillies Sep 26, 2022
384d733
Update win-wheels.yaml
sgillies Sep 26, 2022
27ce74e
Add a baseline
sgillies Sep 27, 2022
568e337
Add versions feature flag
sgillies Sep 27, 2022
0627404
Build maint-1.3
sgillies Sep 27, 2022
9c84f6c
Update win-wheels.yaml
sgillies Sep 27, 2022
8b354e1
Fix PROJ_LIB directory for PROJ 9.1+
snowman2 Sep 27, 2022
1c3e76d
Try manifest feature flag and check against fiona
sgillies Sep 29, 2022
906492a
vcpkg'ing before the checkout action
sgillies Sep 29, 2022
0125bb7
Add debugging
sgillies Sep 29, 2022
9606efc
Use bash shell
sgillies Sep 29, 2022
78e4951
change directory before running vcpkg
sgillies Sep 29, 2022
f449814
checkout step
sgillies Sep 29, 2022
436371d
Remove baseline
sgillies Sep 29, 2022
e6cfbe7
Add vcpkg as submodule
sgillies Sep 29, 2022
8c447a0
Install vcpkg using cmd
sgillies Sep 29, 2022
1a79d33
Get submodules
sgillies Sep 29, 2022
030b141
Bootstrap vcpkg as separate step
sgillies Sep 29, 2022
228febf
Remove platform tags from manifest
sgillies Sep 29, 2022
6b1dcac
Try adding a baseline and using builtin vcpkg
sgillies Sep 30, 2022
fc88497
Back to submodule vcpkg
sgillies Sep 30, 2022
3ad5c93
Use gitsha of vcpkg 2022.09.27
sgillies Sep 30, 2022
dd5cdd7
Use vcpkg 2022.09.27
sgillies Sep 30, 2022
be1c1b5
GDAL 3.5.2 isn't available in a vcpkg release yet
sgillies Sep 30, 2022
9c5b717
Override VCPKG_INSTALLATION_ROOT set by GHA
sgillies Sep 30, 2022
67b1737
Try GDAL 3.5.2 again
sgillies Sep 30, 2022
2cb9dc3
One more override try
sgillies Sep 30, 2022
4a3baa9
Use default (powershell) more often
sgillies Sep 30, 2022
29898ff
Come on!
sgillies Sep 30, 2022
28f413f
Bootstrap from builtin vcpkg like pyproj does
sgillies Sep 30, 2022
67efe7e
Run step with bash
sgillies Sep 30, 2022
cbf59f6
Suss out install directory changes
sgillies Oct 3, 2022
1231248
Specify install root
sgillies Oct 3, 2022
a50e1c8
Try to find GDAL after installation
sgillies Oct 5, 2022
435b3f1
add x-install-root
snowman2 Oct 5, 2022
6a10695
Remove commands destined to fail
sgillies Oct 6, 2022
cede055
Moar debugging
sgillies Oct 6, 2022
ce2cc73
manifests with an s
sgillies Oct 6, 2022
002224c
Set manifest root, grasping at straws
sgillies Oct 6, 2022
bb2a2d2
Use capital C in drive path
snowman2 Oct 7, 2022
f272e0b
Remove vcpkg from gitmodules
snowman2 Oct 7, 2022
e936b18
Search for GDAL_DATA directory
snowman2 Oct 7, 2022
576cfff
Add VCPKG_DEFAULT_TRIPLET
snowman2 Oct 7, 2022
e139045
fix PROJ_:LIB for PROJ 9.0.1
snowman2 Oct 7, 2022
1cad786
Skip 2 tests on Windows
sgillies Oct 11, 2022
d1c8a80
Remove submodule directory
sgillies Oct 11, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
56 changes: 37 additions & 19 deletions .github/workflows/win-wheels.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ name: Windows wheels
on: [push, pull_request, workflow_dispatch]

env:
REF: 1.3.2
REF: maint-1.3

# cancel running jobs on new commit to PR
concurrency:
Expand All @@ -30,29 +30,25 @@ jobs:
- name: Checkout
uses: actions/checkout@v3
with:
repository: rasterio/rasterio
ref: ${{ env.REF }}

- name: Add to rasterio setup.cfg
shell: bash
run: |
echo -e "\n[build_ext]" >> setup.cfg
echo "include_dirs = C:/vcpkg/installed/x64-windows/include" >> setup.cfg
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed this used to be capitalized here and it wasn't below. I am wondering if it is case sensitive.

echo "libraries = gdal" >> setup.cfg
echo "library_dirs = C:/vcpkg/installed/x64-windows/lib" >> setup.cfg
cat setup.cfg
submodules: true

- name: Cache vcpkg
uses: actions/cache@v1
uses: actions/cache@v3
id: vcpkgcache
with:
path: C:/vcpkg/installed
key: ${{ runner.os }}-vcpkg-${{ hashFiles('.github/workflows/*') }}
key: ${{ runner.os }}-vcpkg-${{ hashFiles('.github/workflows/*', 'vcpkg.json') }}-1

- name: Bootstrap vcpkg
run: |
./vcpkg/bootstrap-vcpkg.bat

- name: Install GDAL
- name: Install C Packages (GDAL et al)
shell: bash
run: |
vcpkg install gdal:x64-windows
vcpkg list
ls -l vcpkg
./vcpkg/vcpkg install --feature-flags="versions,manifest"
./vcpkg/vcpkg list

- name: Debug listing
shell: bash
Expand All @@ -67,6 +63,22 @@ jobs:
with:
path: ${{ matrix.vcpkg_logs }}

- name: Checkout
uses: actions/checkout@v3
with:
repository: rasterio/rasterio
fetch-depth: 0
ref: ${{ env.REF }}

- name: Add to rasterio setup.cfg
shell: bash
run: |
echo -e "\n[build_ext]" >> setup.cfg
echo "include_dirs = C:/vcpkg/installed/x64-windows/include" >> setup.cfg
echo "libraries = gdal" >> setup.cfg
echo "library_dirs = C:/vcpkg/installed/x64-windows/lib" >> setup.cfg
cat setup.cfg

- name: Build wheels
uses: pypa/cibuildwheel@v2.3.1
env:
Expand All @@ -77,8 +89,8 @@ jobs:
GDAL_LIBRARY_PATH="$VCPKG_INSTALL/lib"
PACKAGE_DATA=1
GDAL_DATA="$VCPKG_INSTALL/share/gdal"
PROJ_LIB="$VCPKG_INSTALL/share/proj/data"
GDAL_VERSION="3.5.1"
PROJ_LIB="$VCPKG_INSTALL/share/proj"
GDAL_VERSION="3.5.2"
CIBW_BEFORE_BUILD_WINDOWS: pip install delvewheel
CIBW_REPAIR_WHEEL_COMMAND_WINDOWS: delvewheel repair --add-path C:/vcpkg/installed/x64-windows/bin -w {dest_dir} {wheel}

Expand Down Expand Up @@ -130,3 +142,9 @@ jobs:
python test_fiona_issue383.py
cp -R rasterio/tests tests
PROJ_NETWORK=ON python -m pytest -vv tests -m "not gdalbin" -k "not test_ensure_env_decorator_sets_gdal_data_prefix and not test_tiled_dataset_blocksize_guard and not test_untiled_dataset_blocksize and not test_positional_calculation_byindex and not test_transform_geom_polygon and not test_reproject_error_propagation and not test_issue2353 and not test_info_azure_unsigned and not test_decimated_no_use_overview and not test_datasetreader_ctor_url"

- name: Check for conflicts with fiona wheel
shell: bash
run: |
python -m pip install --pre fiona
python -c "import fiona; import rasterio; print(rasterio.show_versions())"
3 changes: 3 additions & 0 deletions .gitmodules
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,6 @@
[submodule "multibuild"]
path = multibuild
url = https://github.com/multi-build/multibuild.git
[submodule "vcpkg"]
path = vcpkg
url = https://github.com/microsoft/vcpkg.git
1 change: 1 addition & 0 deletions vcpkg
Submodule vcpkg added at 57d319
7 changes: 5 additions & 2 deletions vcpkg.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
{
"dependencies": [ "gdal" ],
"name": "rasterio",
"version": "1.3.3",
"dependencies": [ "gdal:x64-windows" ],
"builtin-baseline": "57d3194e702a2959e86a6748999ad71fc24f7922",
"overrides": [
{ "name": "gdal", "version": "3.4.3#2" }
{ "name": "proj:x64-windows", "version": "9.0.1" }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can specify the default triplet as an Env variable (see eg https://github.com/geopandas/pyogrio/blob/d1714041153416c0358658746a6b95f067c835a5/.github/workflows/release.yml#L165), so you don't need to specify it here (that causes the current error I think)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And same for gdal above

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(it's also the default triplet, I assume, so your last commit to just remove it might indeed be sufficient)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far so good! 🤞

]
}