Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update LND to v0.15.2 (URGENT - hot fix) #1083

Merged
merged 5 commits into from Oct 10, 2022
Merged

Update LND to v0.15.2 (URGENT - hot fix) #1083

merged 5 commits into from Oct 10, 2022

Conversation

VajraOfIndra
Copy link
Collaborator

@VajraOfIndra VajraOfIndra commented Sep 2, 2022 •
edited

What

  • Update LND guide to v0.15.2, an emergency hot fix for a bug that cause lnd nodes to be unable to parse certain large blocks.

Not upgrading can lead to loss of funds.

Why

  • Urgent bug fix.

Scope

  • significant change to core configuration
  • minor change to core configuration
  • independent bonus guide
  • simple bug fix

Test & maintenance

  • Check that all occurences of version number has been updated
  • Test the update and that LND is sync to chain:

$ lncli getinfo | grep synced_to_chain

"synced_to_chain": true,

@VajraOfIndra VajraOfIndra added the application-update Update of 3rd-party application label Sep 2, 2022
twofaktor
twofaktor approved these changes Sep 2, 2022
View reviewed changes
Copy link
Collaborator

@twofaktor twofaktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

blckbx
blckbx approved these changes Sep 2, 2022
View reviewed changes
Copy link
Collaborator

@blckbx blckbx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Bitcoinite
Bitcoinite approved these changes Sep 2, 2022
View reviewed changes
Copy link
Contributor

@Bitcoinite Bitcoinite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sig-noi
sig-noi approved these changes Sep 2, 2022
View reviewed changes
Copy link
Contributor

@sig-noi sig-noi left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!
wish my lnd hadn't broken (maybe corrupted macaroon files) when I did the update but I think that was either user error or coincidental. In either case not an issue with the installation guide as well as I can tell.

kristapsk
kristapsk approved these changes Sep 8, 2022
View reviewed changes
Copy link
Collaborator

@kristapsk kristapsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Successfully upgraded my instance.

@kristapsk
Copy link
Collaborator

It looks there is bug in LND v0.15.1 regarding opening new channels to CLN nodes. My suggestion is to skip upgrade to v0.15.1 and wait for v0.15.2 (there is already fix merged into master). lightningnetwork/lnd#6882

@twofaktor
Copy link
Collaborator

It looks there is bug in LND v0.15.1 regarding opening new channels to CLN nodes. My suggestion is to skip upgrade to v0.15.1 and wait for v0.15.2 (there is already fix merged into master). lightningnetwork/lnd#6882

I agree with you, we should wait 🧐

@kristapsk kristapsk self-requested a review September 8, 2022 11:45
@kristapsk kristapsk marked this pull request as draft September 8, 2022 11:46
@VajraOfIndra VajraOfIndra marked this pull request as ready for review October 10, 2022 06:34
blckbx
blckbx approved these changes Oct 10, 2022
View reviewed changes
Copy link
Collaborator

@blckbx blckbx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💥

@VajraOfIndra VajraOfIndra changed the title Update LND to v0.15.1 Update LND to v0.15.2 (URGENT - hot fix) Oct 10, 2022
@VajraOfIndra VajraOfIndra merged commit 93f37c0 into raspibolt:master Oct 10, 2022
@VajraOfIndra VajraOfIndra deleted the lnd-update branch October 10, 2022 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blckbx blckbx blckbx approved these changes

@twofaktor twofaktor twofaktor approved these changes

@Bitcoinite Bitcoinite Bitcoinite approved these changes

@sig-noi sig-noi sig-noi approved these changes

@kristapsk kristapsk Awaiting requested review from kristapsk

Assignees
No one assigned
Labels
application-update Update of 3rd-party application
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@VajraOfIndra @kristapsk @twofaktor @blckbx @Bitcoinite @sig-noi