New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/react18 #233
Chore/react18 #233
Conversation
Awesome thank you! 👍 A new version of react-i18next was released which fixes that issue. :) Currently on holiday so will look at it in a few days :) |
Looked into the Instead of commenting out the code, could you just Looks like it's just the tests which are not working. App seems good 👍 Wouldn't have a problem merging this and adding a task to fix the tests. |
Commenting out was left from the degbugging session. That's why the PR was marked a draft.
Ah, good to know. Couldn't really test because I didn't know how to handle new "setup"-view 😊 |
Yeah, my bad sorry. In the Then it works. Sorry for that, due to the confusion with the setup (in the other branch its |
Pushed it into master, should work now :) |
9e3f20d
to
54eda57
Compare
Thank you very much! :) 👍 🙌 |
Update React setup (incl. Jest) to v18
act
. This seems to be a thing of React v18Created test: fix skipped tests after react v18 update #234 for this
I'll try to finish this up when possible.