Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/react18 #233

Merged
merged 8 commits into from Apr 16, 2022
Merged

Chore/react18 #233

merged 8 commits into from Apr 16, 2022

Conversation

escapedcat
Copy link
Collaborator

@escapedcat escapedcat commented Apr 10, 2022

Update React setup (incl. Jest) to v18

I'll try to finish this up when possible.

@cstenglein
Copy link
Collaborator

Awesome thank you! 👍

A new version of react-i18next was released which fixes that issue. :)

Currently on holiday so will look at it in a few days :)

@cstenglein cstenglein marked this pull request as ready for review April 15, 2022 18:15
@cstenglein cstenglein self-requested a review April 15, 2022 18:15
@cstenglein
Copy link
Collaborator

cstenglein commented Apr 16, 2022

Looked into the act but was only able to fix it with a workaround.

Instead of commenting out the code, could you just xtest them and write a TODO comment? Would be easier. :)

Looks like it's just the tests which are not working. App seems good 👍

Wouldn't have a problem merging this and adding a task to fix the tests.

@escapedcat
Copy link
Collaborator Author

Looked into the act but was only able to fix it with a workaround.
Instead of commenting out the code, could you just xtest them and write a TODO comment? Would be easier. :)

Commenting out was left from the degbugging session. That's why the PR was marked a draft.
But yes, if we want to merge this already I can switch to .skip I guess and get back to fixing the tests later on.

Looks like it's just the tests which are not working. App seems good 👍

Ah, good to know. Couldn't really test because I didn't know how to handle new "setup"-view 😊

@cstenglein
Copy link
Collaborator

Yeah, my bad sorry. In the backend-mock it should be DONE, not done: https://github.com/cstenglein/raspiblitz-web/blob/master/backend-mock/setup.js#L10=

Then it works. Sorry for that, due to the confusion with the setup (in the other branch its done in lowercase).

@cstenglein
Copy link
Collaborator

Pushed it into master, should work now :)

@cstenglein cstenglein merged commit 6d9ff5c into master Apr 16, 2022
@cstenglein
Copy link
Collaborator

Thank you very much! :) 👍 🙌

@cstenglein cstenglein deleted the chore/react18 branch April 16, 2022 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants