This repository has been archived by the owner on Aug 7, 2023. It is now read-only.
small fixes for cupy11 #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivialfis
reviewed
Oct 18, 2022
tests/python-gpu/test_from_cupy.py
Outdated
| @@ -220,4 +220,5 @@ def test_specified_device(self): | |||
| np.float32, xgb.DeviceQuantileDMatrix, np.nan) | |||
| with pytest.raises(xgb.core.XGBoostError): | |||
| xgb.train({'tree_method': 'gpu_hist', 'gpu_id': 1}, | |||
| 'fail_on_invalid_gpu_id': True}, | |||
There was a problem hiding this comment.
This should fail without additional parameters assuming there is more than 1 device available during testing.
Co-authored-by: Jiaming Yuan <jm.yuan@outlook.com>
remove unnecessary option
|
Do we also need to submit an upstream patch for this as well ? |
Thank you for the fix. It's fixed in upstream (but with some refactoring so this PR is still the best option for rapids). |
trivialfis
approved these changes
Oct 18, 2022
|
@trivialfis / @dantegd can this be merged in ? |
|
I don't have write access |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @trivialfis @dantegd
This are fixes needed for CuPy 11 which will also be consumed by DLFW -- i'm using them in 22.10 as well