Pin Distributed to last working version #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
approved these changes
Jan 11, 2024
| @@ -13,7 +13,7 @@ version = "24.02.00a0" | |||
| description = "Dask and Distributed version pinning for RAPIDS" | |||
| dependencies = [ | |||
| "dask @ git+https://github.com/dask/dask.git@main", | |||
| "distributed @ git+https://github.com/dask/distributed.git@main", | |||
| "distributed @ git+https://github.com/dask/distributed.git@7562f9c566978de4f3f5b73920a24ea1813d6e28", | |||
There was a problem hiding this comment.
Technically I think we could go one commit later (964abea0fee437463585ffdfa5a8862ec7431f18) but since this is just a temporary workaround pinning I'm fine merging this as is.
There was a problem hiding this comment.
Yeah there wasn't a Conda package for that commit and thought it was better to pick one where both Conda & Pip used the same "version" to avoid potential discrepancies between the two
|
Thanks Vyas! 🙏 |
vyasr
added a commit
to vyasr/rapids-dask-dependency
that referenced
this pull request
Jan 12, 2024
This reverts commit 4a2dd6f.
vyasr
added a commit
that referenced
this pull request
Jan 12, 2024
This reverts commit 4a2dd6f. The upstream distributed bug was fixed in dask/distributed#8456.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To workaround issue ( dask/distributed#8454 ), pin Distributed to a version before PR ( dask/distributed#8443 ) was included