Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update memory_pause_fraction in test_spill #757

Merged
merged 2 commits into from Oct 20, 2021
Merged

Update memory_pause_fraction in test_spill #757

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e8978a
Update memory_pause_fraction in test_spill
pentschev Oct 20, 2021
a09332c
Remove lingering print statement
pentschev Oct 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions dask_cuda/benchmarks/local_cudf_shuffle.py
View file
Open in desktop
Expand Up @@ -82,6 +82,7 @@ def main(args):
"ignore", message=".*NVLink.*rmm_pool_size.*", category=UserWarning
)

print(cluster_kwargs)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this leftover from testing or you do want to print kwargs ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is something I was using for a different test and didn't see when committing, good catch. Removed it now.

cluster = Cluster(*cluster_args, **cluster_kwargs)
if args.multi_node:
import time
Expand Down
24 changes: 12 additions & 12 deletions dask_cuda/tests/test_spill.py
View file
Open in desktop
Expand Up @@ -89,23 +89,23 @@ def delayed_worker_assert(total_size, device_chunk_overhead, serialized_chunk_ov
"memory_limit": int(800e6),
"host_target": 0.0,
"host_spill": 0.0,
"host_pause": None,
"host_pause": 0.0,
"spills_to_disk": False,
},
{
"device_memory_limit": int(200e6),
"memory_limit": int(200e6),
"host_target": 0.0,
"host_spill": 0.0,
"host_pause": None,
"host_pause": 0.0,
"spills_to_disk": True,
},
{
"device_memory_limit": int(200e6),
"memory_limit": 0,
"host_target": 0.0,
"host_spill": 0.0,
"host_pause": None,
"host_pause": 0.0,
"spills_to_disk": False,
},
],
Expand Down Expand Up @@ -167,23 +167,23 @@ def test_device_spill(client, scheduler, worker):
"memory_limit": int(800e6),
"host_target": 0.0,
"host_spill": 0.0,
"host_pause": None,
"host_pause": 0.0,
"spills_to_disk": False,
},
{
"device_memory_limit": int(200e6),
"memory_limit": int(200e6),
"host_target": 0.0,
"host_spill": 0.0,
"host_pause": None,
"host_pause": 0.0,
"spills_to_disk": True,
},
{
"device_memory_limit": int(200e6),
"memory_limit": 0,
"host_target": 0.0,
"host_spill": 0.0,
"host_pause": None,
"host_pause": 0.0,
"spills_to_disk": False,
},
],
Expand Down Expand Up @@ -243,23 +243,23 @@ async def test_cupy_cluster_device_spill(params):
"memory_limit": int(800e6),
"host_target": 0.0,
"host_spill": 0.0,
"host_pause": None,
"host_pause": 0.0,
"spills_to_disk": False,
},
{
"device_memory_limit": int(200e6),
"memory_limit": int(200e6),
"host_target": 0.0,
"host_spill": 0.0,
"host_pause": None,
"host_pause": 0.0,
"spills_to_disk": True,
},
{
"device_memory_limit": int(200e6),
"memory_limit": 0,
"host_target": 0.0,
"host_spill": 0.0,
"host_pause": None,
"host_pause": 0.0,
"spills_to_disk": False,
},
],
Expand Down Expand Up @@ -332,23 +332,23 @@ def test_device_spill(client, scheduler, worker):
"memory_limit": int(800e6),
"host_target": 0.0,
"host_spill": 0.0,
"host_pause": None,
"host_pause": 0.0,
"spills_to_disk": False,
},
{
"device_memory_limit": int(200e6),
"memory_limit": int(200e6),
"host_target": 0.0,
"host_spill": 0.0,
"host_pause": None,
"host_pause": 0.0,
"spills_to_disk": True,
},
{
"device_memory_limit": int(200e6),
"memory_limit": 0,
"host_target": 0.0,
"host_spill": 0.0,
"host_pause": None,
"host_pause": 0.0,
"spills_to_disk": False,
},
],
Expand Down