Skip to content

Commit

Permalink
Update memory_pause_fraction in test_spill (#757)
Browse files Browse the repository at this point in the history
Changes from dask/distributed#5438 have slightly
modified the behavior for worker spilling options, thus we need to
update memory_pause_fraction to a value that isn't `None`.

Authors:
  - Peter Andreas Entschev (https://github.com/pentschev)

Approvers:
  - Benjamin Zaitlen (https://github.com/quasiben)

URL: #757
  • Loading branch information
pentschev committed Oct 20, 2021
1 parent 05c95f0 commit e9a291a
Showing 1 changed file with 12 additions and 12 deletions.
24 changes: 12 additions & 12 deletions dask_cuda/tests/test_spill.py
Expand Up @@ -89,23 +89,23 @@ def delayed_worker_assert(total_size, device_chunk_overhead, serialized_chunk_ov
"memory_limit": int(800e6),
"host_target": 0.0,
"host_spill": 0.0,
"host_pause": None,
"host_pause": 0.0,
"spills_to_disk": False,
},
{
"device_memory_limit": int(200e6),
"memory_limit": int(200e6),
"host_target": 0.0,
"host_spill": 0.0,
"host_pause": None,
"host_pause": 0.0,
"spills_to_disk": True,
},
{
"device_memory_limit": int(200e6),
"memory_limit": 0,
"host_target": 0.0,
"host_spill": 0.0,
"host_pause": None,
"host_pause": 0.0,
"spills_to_disk": False,
},
],
Expand Down Expand Up @@ -167,23 +167,23 @@ def test_device_spill(client, scheduler, worker):
"memory_limit": int(800e6),
"host_target": 0.0,
"host_spill": 0.0,
"host_pause": None,
"host_pause": 0.0,
"spills_to_disk": False,
},
{
"device_memory_limit": int(200e6),
"memory_limit": int(200e6),
"host_target": 0.0,
"host_spill": 0.0,
"host_pause": None,
"host_pause": 0.0,
"spills_to_disk": True,
},
{
"device_memory_limit": int(200e6),
"memory_limit": 0,
"host_target": 0.0,
"host_spill": 0.0,
"host_pause": None,
"host_pause": 0.0,
"spills_to_disk": False,
},
],
Expand Down Expand Up @@ -243,23 +243,23 @@ async def test_cupy_cluster_device_spill(params):
"memory_limit": int(800e6),
"host_target": 0.0,
"host_spill": 0.0,
"host_pause": None,
"host_pause": 0.0,
"spills_to_disk": False,
},
{
"device_memory_limit": int(200e6),
"memory_limit": int(200e6),
"host_target": 0.0,
"host_spill": 0.0,
"host_pause": None,
"host_pause": 0.0,
"spills_to_disk": True,
},
{
"device_memory_limit": int(200e6),
"memory_limit": 0,
"host_target": 0.0,
"host_spill": 0.0,
"host_pause": None,
"host_pause": 0.0,
"spills_to_disk": False,
},
],
Expand Down Expand Up @@ -332,23 +332,23 @@ def test_device_spill(client, scheduler, worker):
"memory_limit": int(800e6),
"host_target": 0.0,
"host_spill": 0.0,
"host_pause": None,
"host_pause": 0.0,
"spills_to_disk": False,
},
{
"device_memory_limit": int(200e6),
"memory_limit": int(200e6),
"host_target": 0.0,
"host_spill": 0.0,
"host_pause": None,
"host_pause": 0.0,
"spills_to_disk": True,
},
{
"device_memory_limit": int(200e6),
"memory_limit": 0,
"host_target": 0.0,
"host_spill": 0.0,
"host_pause": None,
"host_pause": 0.0,
"spills_to_disk": False,
},
],
Expand Down

0 comments on commit e9a291a

Please sign in to comment.