-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor API context managers #5142
base: branch-23.04
Are you sure you want to change the base?
Refactor API context managers #5142
Conversation
This change is intended to not be breaking, but I have labeled it as breaking until we have checked that it is not. |
b18dd90
to
7ecabc8
Compare
7ecabc8
to
c171cae
Compare
0c860b7
to
f8a3106
Compare
Codecov ReportBase: 67.17% // Head: 66.75% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-23.02 #5142 +/- ##
================================================
- Coverage 67.17% 66.75% -0.42%
================================================
Files 192 191 -1
Lines 12425 12235 -190
================================================
- Hits 8346 8167 -179
+ Misses 4079 4068 -11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
a8677ef
to
9089f17
Compare
Better design, but also simplifies temporarily replacing the context within the exit_internal_api() context.
And slightly adjust variable names.
a1b804d
to
b5fc198
Compare
No description provided.