Add MTMG support for Similarity and test for all-pairs Jaccard #4411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added vertex_pair_result to handle algorithms that return a vertex_pair and a result, like Jaccard, et. al. Some test updates didn't get replicated into mtmg test code, made those changes Still have debugging in these files since I'm not done debugging
ChuckHastings
added
improvement
KyleFromNVIDIA
approved these changes
May 13, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added to the MTMG library support for results that contain a vertex pair and a result. This will allow for support for all of the similarity algorithms.
Added an MTMG test that demonstrates how to call all-pairs Jaccard.
Also cleaned up the cmake files to better find ucx/ucs/ucp.
Closes https://github.com/rapidsai/graph_dl/issues/331