-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix building cugraph with CCCL main #4404
base: branch-24.06
Are you sure you want to change the base?
Conversation
The new While this is possible in CCCL 2.2.0's version of I commented out the The problem case is when the Alternatively, I attempted to specialize the cc: @BradReesWork if you have any ideas or know the right person to help fix this. |
The nvcc error tells us half of the issue:
The error from clang tells us the other half:
Combining info from both errors, the issue is that when But |
@seunghwak is our expert in this area |
Fixes a broken link https://github.com/rapidsai/cugraph-ops/blob/branch-23.04/README.md -> https://github.com/rapidsai/cugraph/blob/branch-24.04/readme_pages/cugraph_ops.md Authors: - Ray Bell (https://github.com/raybellwaves) - Alex Barghi (https://github.com/alexbarghi-nv) - Rick Ratzel (https://github.com/rlratzel) Approvers: - Don Acosta (https://github.com/acostadon) URL: rapidsai#4279
FORK trxcllnt | ||
PINNED_TAG fix/cccl-2.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to revert this before merging:
FORK trxcllnt | |
PINNED_TAG fix/cccl-2.5 | |
FORK rapidsai | |
PINNED_TAG branch-${CUGRAPH_ETL_BRANCH_VERSION_cudf} |
@@ -1,5 +1,5 @@ | |||
#============================================================================= | |||
# Copyright (c) 2021, NVIDIA CORPORATION. | |||
# Copyright (c) 2021-2024, NVIDIA CORPORATION. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to revert this before merging:
# Copyright (c) 2021-2024, NVIDIA CORPORATION. | |
# Copyright (c) 2021, NVIDIA CORPORATION. |
It looks like the main build is working, but the wheel builds are blocked by #4436? |
Similar to rapidsai/cudf#15552, we are testing building RAPIDS with CCCL's main branch to get ahead of any breaking changes.