Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use rapids-build-backend #4393

Open
wants to merge 38 commits into
base: branch-24.08
Choose a base branch
from
Open

Use rapids-build-backend #4393

wants to merge 38 commits into from
+465 −262

Conversation

KyleFromNVIDIA
Copy link
Contributor

Contributes to rapidsai/build-planning#31.

@KyleFromNVIDIA KyleFromNVIDIA requested review from a team as code owners May 7, 2024 19:18
@github-actions github-actions bot added the conda label May 8, 2024
@KyleFromNVIDIA KyleFromNVIDIA mentioned this pull request May 15, 2024
Open
@KyleFromNVIDIA KyleFromNVIDIA added improvement Improvement / enhancement to an existing function DO NOT MERGE Hold off on merging; see PR for details non-breaking Non-breaking change labels May 16, 2024
@rlratzel
Copy link
Contributor

It's my understanding that this PR should now target 24.08 (see here)

@KyleFromNVIDIA KyleFromNVIDIA requested a review from a team as a code owner May 21, 2024 13:57
@KyleFromNVIDIA KyleFromNVIDIA changed the base branch from branch-24.06 to branch-24.08 May 21, 2024 13:57
@KyleFromNVIDIA KyleFromNVIDIA removed the DO NOT MERGE Hold off on merging; see PR for details label May 22, 2024
@BradReesWork BradReesWork added this to the 24.08 milestone May 28, 2024
jameslamb
jameslamb reviewed May 29, 2024
View reviewed changes
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left 2 comments for your consideration, leaving a non-blocking "comment" review so my review doesn't block merging whenever those (and other reviewers' comments) are addressed.

python/cugraph-equivariant/cugraph_equivariant/_version.py Show resolved Hide resolved
python/cugraph-equivariant/cugraph_equivariant/_version.py Outdated Show resolved Hide resolved
@jameslamb jameslamb mentioned this pull request May 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameslamb jameslamb jameslamb left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ci conda improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python
Projects
None yet
Milestone
24.08
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@KyleFromNVIDIA @rlratzel @jameslamb @BradReesWork