Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add --rm and --name to devcontainer run args #4361

Merged
merged 6 commits into from
May 20, 2024
Merged

add --rm and --name to devcontainer run args #4361

merged 6 commits into from
May 20, 2024

Conversation

trxcllnt
Copy link
Collaborator

@trxcllnt trxcllnt commented Apr 19, 2024 •
edited

  • Remove the devcontainer when the VSCode window closes
  • Adds a descriptive name to the running container: 
    $ docker ps -a
CONTAINER ID   IMAGE            ...  NAMES
0dbb364fe544   vsc-cugraph-...  ...  rapids-cugraph-24.06-cuda12.2-conda

$ docker rm -f rapids-cugraph-24.06-cuda12.2-conda

@trxcllnt trxcllnt added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 19, 2024
@trxcllnt trxcllnt mentioned this pull request Apr 19, 2024
Merged
@trxcllnt trxcllnt requested a review from a team as a code owner April 22, 2024 17:17
@github-actions github-actions bot added the ci label Apr 22, 2024
@rlratzel
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit b9f6e8c into rapidsai:branch-24.06 May 20, 2024
131 of 132 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raydouglass raydouglass raydouglass approved these changes

Assignees
No one assigned
Labels
ci improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@trxcllnt @rlratzel @raydouglass @nv-rliu