Defer to C++ equality and hashing for pylibcudf DataType and Aggregation objects #15732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wence-
added
improvement
The C++ data_type type implements operator==, so we should use it in Cython to avoid the definitions ever going out of sync.
Use the matching C++ implementations for OAOO.
wence-
force-pushed
the
wence/fea/pylibcudf-oaoo
branch
from
c0089bb
to
f67922a
Compare
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since the C++ layer provides implementations of these, use them, rather than redoing an implementation. This avoids things ever getting out of sync.
Checklist