Stop instantiate GPU objects in the parametrize test args #15652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdice
reviewed
May 4, 2024
Comment on lines
+2002
to
+2003
| _dict = {k: c(**v) for k, (c, v) in d.items()} | ||
| cudf.concat(_dict, axis=1) |
There was a problem hiding this comment.
It's probably okay to overwrite the input variable name here.
Suggested change
| _dict = {k: c(**v) for k, (c, v) in d.items()} | |
| cudf.concat(_dict, axis=1) | |
| d = {k: c(**v) for k, (c, v) in d.items()} | |
| cudf.concat(d, axis=1) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #15651
GPU object instantiation within the parametrize arguments results in the test suite being slower to launch. We should refactor tests to prevent this.
This PR is based off b5b9116
Checklist