Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work around issues with cccl main #15552

Merged
merged 49 commits into from
May 28, 2024
Merged

Work around issues with cccl main #15552

merged 49 commits into from
May 28, 2024

Conversation

miscco
Copy link
Contributor

@miscco miscco commented Apr 17, 2024

This gets cuDF build cccl main on 12.3.

There is one issue with the cuco tuple helpers but that will be fixed on the cuco side

@miscco miscco requested a review from a team as a code owner April 17, 2024 16:09
@miscco miscco requested review from bdice and ttnghia April 17, 2024 16:09
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Apr 17, 2024
bdice
bdice approved these changes Apr 17, 2024
View reviewed changes
cpp/src/io/comp/statistics.cu Outdated Show resolved Hide resolved
cpp/src/io/parquet/page_string_decode.cu Outdated Show resolved Hide resolved
@bdice bdice added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 17, 2024
@ttnghia
Copy link
Contributor

ttnghia commented Apr 17, 2024

/ok to test

@bdice
Copy link
Contributor

bdice commented Apr 17, 2024 •
edited

@miscco I went ahead and applied my two (small) suggestions, so we can get CI run and merge this sooner. These aren't controversial changes so we should be able to move this forward.

@bdice
Copy link
Contributor

bdice commented Apr 17, 2024

/ok to test

@ttnghia
Copy link
Contributor

ttnghia commented Apr 19, 2024

/ok to test

@trxcllnt
Copy link
Contributor

/ok to test

@trxcllnt
Copy link
Contributor

trxcllnt commented May 8, 2024

@miscco I'm using this branch in NVIDIA/cccl#1667, will be updating this branch until that PR can build cudf.

@miscco miscco requested a review from a team as a code owner May 8, 2024 20:03
trxcllnt
trxcllnt reviewed May 23, 2024
View reviewed changes
rapids_config.cmake Outdated Show resolved Hide resolved
rapids-bot bot pushed a commit to rapidsai/cuspatial that referenced this pull request May 25, 2024
@trxcllnt
Fix building cuspatial with CCCL main (#1382)
559bcc7 
Similar to rapidsai/cudf#15552, we are testing [building RAPIDS with CCCL's main branch](NVIDIA/cccl#1667) to get ahead of any breaking changes.

Authors:
  - Paul Taylor (https://github.com/trxcllnt)

Approvers:
  - Mark Harris (https://github.com/harrism)

URL: #1382
@raydouglass raydouglass merged commit 29429f7 into rapidsai:branch-24.06 May 28, 2024
69 of 70 checks passed
@miscco miscco deleted the fix_cccl_compat branch May 28, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trxcllnt trxcllnt trxcllnt left review comments

@harrism harrism harrism left review comments

@bdice bdice bdice approved these changes

@PointKernel PointKernel PointKernel left review comments

@raydouglass raydouglass raydouglass approved these changes

@ttnghia ttnghia ttnghia approved these changes

@davidwendt davidwendt davidwendt approved these changes

@msarahan msarahan Awaiting requested review from msarahan msarahan is a code owner automatically assigned from rapidsai/ci-codeowners

Assignees

@miscco miscco

Labels
CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
cuDF/Dask/Numba/UCX
Status: Done
libcudf
Status: Burndown
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@miscco @ttnghia @bdice @trxcllnt @harrism @raydouglass @PointKernel @davidwendt