[REVIEW] Switch language from None to "en" in docs build
#11133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galipremsagar
added
3 - Ready for Review
galipremsagar
commented
Jun 22, 2022
| def test_read_parquet_multiple_files(datadir): | ||
| df_1_path = datadir / "df_1.parquet" | ||
| df_2_path = datadir / "df_2.parquet" | ||
| def test_read_parquet_multiple_files(tmpdir): |
There was a problem hiding this comment.
This shouldn't be a datadir, but should be a tmpdir. Fixed it in this PR as it is a trivial change.
bdice
approved these changes
Jun 22, 2022
galipremsagar
added
5 - Ready to Merge
jakirkham
approved these changes
Jun 22, 2022
Codecov Report
@@ Coverage Diff @@
## branch-22.08 #11133 +/- ##
===============================================
Coverage ? 86.34%
===============================================
Files ? 144
Lines ? 22729
Branches ? 0
===============================================
Hits ? 19625
Misses ? 3104
Partials ? 0 Continue to review full report at Codecov.
|
raydouglass
approved these changes
Jun 22, 2022
|
@gpucibot merge |
|
Thanks all! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for Sphinx 5 compatibility. Should fix the following warning occurring in doc builds.
xref: sphinx-doc/sphinx#10481