Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] test_concat file instantiates GPU objects in the parametrize arguments #15651

Open
er-eis opened this issue May 4, 2024 · 1 comment · May be fixed by #15652
Open

[BUG] test_concat file instantiates GPU objects in the parametrize arguments #15651

er-eis opened this issue May 4, 2024 · 1 comment · May be fixed by #15652
Labels
bug Something isn't working

Comments

@er-eis
Copy link
Contributor

er-eis commented May 4, 2024

As @bdice points out here: #15623 (comment)

GPU object instantiation within the parametrize arguments results in the test suite being slower to launch. We should refactor tests as such: b5b9116

Ideally, this refactor would occur across all test files with this associated issue.
@er-eis er-eis added the bug Something isn't working label May 4, 2024
@er-eis er-eis linked a pull request May 4, 2024 that will close this issue
Draft
2 tasks
@vyasr
Copy link
Contributor

vyasr commented May 17, 2024

For reference, the broader ask (refactoring parametrization to either prefer fixtures or move GPU data instantiation into the test to avoid materialization on test collection) is being tracked in #9999. Since you have a PR to close this specific issue, I'm happy to leave this one open, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
cuDF/Dask/Numba/UCX
Status: In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stop instantiate GPU objects in the parametrize test args er-eis/cudf
3 participants
@vyasr @er-eis and others