Bump actions/checkout to version 3.x so we use NodeJs 16.x #17161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwillcox-r7
changed the title
…precated NodeJS 12
gwillcox-r7
force-pushed
the
bump-nodejs-github-actions
branch
from
69984b0
to
2d2ab6b
Compare
adfoster-r7
reviewed
Oct 19, 2022
| @@ -33,7 +33,7 @@ jobs: | |||
| name: Docker Build | |||
| steps: | |||
| - name: Checkout code | |||
| uses: actions/checkout@v2 | |||
| uses: actions/checkout@v3 | |||
There was a problem hiding this comment.
v2 is also present in other Github action files within this repo, which I imagine we'll want to update too?
There was a problem hiding this comment.
Yep let me take a look for those and update them as well.
|
cross-referencing the Github actions PR which bumped the node dependency requirements here - actions/checkout#689 There doesn't seem to be much of a changelog on why this is a major bump: Looks like it's a safe bump and just churn for users? Not sure yet. |
gwillcox-r7
changed the title
|
I'm not sure why this is a major bump to 3, but going through the change log and the links I commented above - nothing stands out to me as being a blocker 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump the NodeJS version used for Verify.yml to fix the following issue:
Issue was first encountered on @h00die's PR at https://github.com/h00die/metasploit-framework/actions/runs/3267771315