Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update ruby-prof version due to broken compile #13464

Merged
merged 1 commit into from May 15, 2020
Merged

update ruby-prof version due to broken compile #13464

merged 1 commit into from May 15, 2020

Conversation

jmartin-tech
Copy link
Contributor

@jmartin-tech jmartin-tech commented May 15, 2020 •
edited by acammack-r7

Nightly releases purposely use older toolchains.
ruby-prof/ruby-prof#272

Verification

List the steps needed to make sure this thing works

  • Omnibus builds gemset successfully

@jmartin-tech
update ruby-prof version due to broken compile
80994e6 
Nightly releases purposely use older toolchains.
ruby-prof/ruby-prof#272
adfoster-r7
adfoster-r7 approved these changes May 15, 2020
View reviewed changes
Copy link
Contributor

@adfoster-r7 adfoster-r7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was a good turnaround time for upstream to fix this 👍

@acammack-r7 acammack-r7 self-assigned this May 15, 2020
@acammack-r7 acammack-r7 merged commit ef71b38 into rapid7:master May 15, 2020
@jmartin-tech jmartin-tech deleted the update-ruby-prof branch May 15, 2020 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adfoster-r7 adfoster-r7 adfoster-r7 approved these changes

Assignees

@acammack-r7 acammack-r7

Labels
bug rn-no-release-notes no release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jmartin-tech @adfoster-r7 @acammack-r7