This repository has been archived by the owner on Oct 27, 2023. It is now read-only.
Use databags for githubapp yaml in ext #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdoughty-r7
reviewed
Oct 27, 2021
| @@ -73,19 +73,34 @@ | |||
| revision attrs['revision'] | |||
| ssh_wrapper "/home/#{node['github_connector']['user']}/.ssh/#{engine}_ssh_wrapper.sh" | |||
| action :sync | |||
| notifies :run, 'rvm_shell[github-connector-gems]', :immediately | |||
| notifies :run, 'rvm_shell[github-csonnector-gems]', :immediately | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the pem files and a temporary pac for github has been added to a new knife data bag called github-apps. the token needs to be updated to use a token from a service account
my one concern is that i know github-connector is open source so i'm not sure if we want to put information / a template file that contains information kind of hinting at how we're using github apps in our open source repo?