Skip to content

Commit

Permalink
Merge latest master into v2-merge-master
Browse files Browse the repository at this point in the history 
commit 41ae52046f3b5fa00a085bf71864126b9e96919d
Merge: 70c9cd9 76c8068
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Thu Sep 12 05:35:50 2019 +0530

    Merge pull request #887 from urfave/asahasrabuddhe-patch-1

    Release 1.22.1

commit 76c8068f0b3ade82badf05230299d44f30e148f8
Merge: c4ed30e 70c9cd9
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Thu Sep 12 05:19:58 2019 +0530

    Merge branch 'master' into asahasrabuddhe-patch-1

commit 70c9cd9327b4fff33c16fe8fc2e9421f3cd8fc94
Merge: 4bc19a5 5b7dd42
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Thu Sep 12 05:19:33 2019 +0530

    Merge pull request #890 from urfave/issue-878

    Fix #878

commit 5b7dd424c1086612b5e12b9b8520390491195af5
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Wed Sep 11 15:10:14 2019 +0530

    Ensure flag is not blank

commit 1385b99db84716fe5aa83c106a4481357839b4b0
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Wed Sep 11 14:42:38 2019 +0530

    Fix Typo

commit e88f2774e44c4ac09228f9c6f31931c2f1ace64f
Merge: 8ac83fd 0fccfe6
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Wed Sep 11 14:37:06 2019 +0530

    Merge branch 'issue-878' of https://github.com/urfave/cli into issue-878

commit 8ac83fdee9cf11e27be72f36a8e0a10eb889f00e
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Wed Sep 11 14:34:41 2019 +0530

    Use iterative logic to determine missing flag

commit 0fccfe68a33da1ff4525f3c10dd67bc0ea77323a
Merge: 0cefd42 4bc19a5
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Wed Sep 11 14:17:11 2019 +0530

    Merge branch 'master' into issue-878

commit 0cefd42204662540abcc2d98fe54e88af99e239b
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Wed Sep 11 14:15:20 2019 +0530

    Modify variable names

commit 4bc19a5c444a08195bb565c478f4e3fa98e567e9
Merge: 77e0806 b201887
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Wed Sep 11 14:13:40 2019 +0530

    Merge pull request #891 from saschagrunert/fish-hidden

    Don't generate fish completion for hidden commands

commit c4ed30e82a8d6c96ddcd53ebb4e1228bc24a67dc
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Wed Sep 11 14:09:50 2019 +0530

    Update CHANGELOG.md

commit b20188768330f444518b8a4eef4e42047bec733a
Merge: 61ce1a5 77e0806
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Wed Sep 11 14:04:44 2019 +0530

    Merge branch 'master' into fish-hidden

commit 77e08067576c497cc648cb33258cdb92868891fc
Merge: af3f8d1 d53aee3
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Wed Sep 11 14:01:44 2019 +0530

    Merge pull request #883 from urfave/remove-flag-generation

    Remove flag generation

commit 61ce1a544173a04f273c31b74075dd366be70cb0
Author: Sascha Grunert <sgrunert@suse.com>
Date:   Wed Sep 11 09:06:02 2019 +0200

    Don't generate fish completion for hidden commands

    Added the missing test case as well.

    Signed-off-by: Sascha Grunert <sgrunert@suse.com>

commit 75128334fd7f47194661494f08dc039ea9fd1f62
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Wed Sep 11 10:34:00 2019 +0530

    Update CHANGELOG.md

commit 823e5e3d73a1c2f2d80f8559f72de3e766244024
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Wed Sep 11 09:21:45 2019 +0530

    Improve Code and Add Test Case

commit d8af431e1794416b9ed3820a8e07adbf54027e21
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Wed Sep 11 08:59:51 2019 +0530

    Fix #878

commit 6a5d2c1b309a6042cdd629c8e398557829188dd8
Merge: 24ee93b af3f8d1
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Wed Sep 11 08:27:45 2019 +0530

    Merge branch 'master' into asahasrabuddhe-patch-1

commit d53aee3ad15ae9a7f770220e7e7eba9d9c1c4c2b
Merge: 29347c2 af3f8d1
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Wed Sep 11 05:39:35 2019 +0530

    Merge branch 'master' into remove-flag-generation

commit 24ee93bf6d6268816bdccf31308d0877032e239d
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Wed Sep 11 05:37:41 2019 +0530

    Update CHANGELOG.md

commit 744d1389806cadcf47d844b0cb67112e338bd250
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Wed Sep 11 05:33:46 2019 +0530

    Update CHANGELOG.md

commit af3f8d1bdc4dbc10f2344c233e3b6ccb8d53866c
Merge: 0aa3cbf 73cdd4a
Author: Audrius Butkevicius <audrius.butkevicius@gmail.com>
Date:   Tue Sep 10 21:28:35 2019 +0100

    Merge pull request #889 from crosbymichael/hidden-man

    Don't output hidden commands for  man pages

commit 73cdd4ad0bbb3a31fc7e9ffc3c750f9251a649a4
Author: Michael Crosby <crosbymichael@gmail.com>
Date:   Tue Sep 10 13:49:11 2019 -0400

    Don't output hidden commands for  man pages

    Signed-off-by: Michael Crosby <crosbymichael@gmail.com>

commit 29347c2062930d673d384d88ad1bfd83b42f96a2
Merge: 989d428 0aa3cbf
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Tue Sep 10 15:04:12 2019 +0530

    Merge branch 'master' into remove-flag-generation

commit 0aa3cbf0894bc60ae0e5e1f625cba9b0a97cf411
Merge: eb93309 5605db3
Author: Audrius Butkevicius <audrius.butkevicius@gmail.com>
Date:   Tue Sep 10 08:28:09 2019 +0100

    Merge pull request #885 from urfave/go-modules-support

    Go modules support

commit 5605db3df217549c2b6f182de9e3c7b7442a4027
Merge: 9f0ff0b eb93309
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Tue Sep 10 06:56:41 2019 +0530

    Merge branch 'master' into go-modules-support

commit 756550797bcb8c942bc95f36c2010d5fa8e1f6a6
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Tue Sep 10 06:42:34 2019 +0530

    Update CHANGELOG.md

commit 9f0ff0b134a203720596ee42353e709bf76b321b
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Tue Sep 10 06:40:45 2019 +0530

    Bump minimum supported version of Go to 1.11

commit 989d428b4bfdda31b151b0f94708537aafa0762e
Merge: 4c52a9d eb93309
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Tue Sep 10 06:33:21 2019 +0530

    Merge branch 'master' into remove-flag-generation

commit eb933099f1b1acd60948e8afe42e41c2816d96c5
Merge: c12433d 224cd4e
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Tue Sep 10 06:24:10 2019 +0530

    Merge pull request #882 from urfave/lynncyrin-patch-1

    Release 1.22.0

commit ccaab7aca0dcff59aaff93535331616bb64d484f
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Mon Sep 9 13:15:47 2019 +0530

    Update .travis.yml

    Set GOPROXY in Travis environment

commit f91fda92061f34c8e1d39e5fd65335819c9720b3
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Mon Sep 9 08:37:16 2019 +0530

    Cleanup after before_script to avoid git diff errors
    remove windows build

commit b945cb983990823aafb8162b4933654639258198
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Mon Sep 9 08:23:04 2019 +0530

    Update gfmrun import command to suite Go Modules pattern
    Fix test command typo in travis script

commit defc3b213c208671c4ecc4c120afda26b8e7ce7c
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Mon Sep 9 08:19:06 2019 +0530

    Add support for Go 1.13
    Drop support for Go 1.11
    Use md2man v2 to avoid dependency issues when building with Go Modules
    Enabled
    Update TravisCI build environment images (trusty was deprecated)
    Add optional Windows build

commit 4c52a9d0400387c5156dd71e6b4c7395a9d36434
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Mon Sep 9 08:12:09 2019 +0530

    Fix AppVeyor build

commit 96a7431e0294c1e7f9839be13cedb697ad17668d
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Mon Sep 9 07:47:18 2019 +0530

    Remove generate script from travis flow
    Remove unused dependencies from travis script

commit ac593521791fcda0a65a99eab68192eec5ffd785
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Mon Sep 9 07:44:07 2019 +0530

    Remove Flag Generation
    Remove Legacy Python Scripts

commit 224cd4e66ada98b9205be1d889452a5edfc15ae6
Author: Lynn Cyrin (they/them) <lynn@textio.com>
Date:   Sat Sep 7 20:44:48 2019 -0700

    Update CHANGELOG.md

commit 1cdb8c5207036c68d7e9656979484b7496c79675
Author: Lynn Cyrin (they/them) <lynn@textio.com>
Date:   Sat Sep 7 20:43:56 2019 -0700

    typo

commit 4443d052ef73d725eb8272db57cbe8f02a3cd40d
Author: Lynn Cyrin (they/them) <lynn@textio.com>
Date:   Sat Sep 7 20:41:44 2019 -0700

    Release 1.22.0

    - adds the changelog for 1.22.0
    - updates the changelog for 1.21.0. some PRs were missed, as was mentioned here https://github.com/urfave/cli/pull/829#issuecomment-517968795
    - closes https://github.com/urfave/cli/issues/867

commit c12433d9e626a6e5fa36db0cedf317c229092aae
Merge: 54ea46a c36563e
Author: Audrius Butkevicius <audrius.butkevicius@gmail.com>
Date:   Fri Aug 30 15:53:55 2019 +0100

    Merge pull request #879 from saschagrunert/escape-single-quotes

    Escape single quotes in fish shell completion

commit c36563ee5701c56990f55c731209f5a64aa2262d
Author: Sascha Grunert <sgrunert@suse.com>
Date:   Thu Aug 29 14:45:32 2019 +0200

    Escape single quotes in fish shell completion

    Single quotes can break the generated fish shell completion and should
    be escaped correctly.

    Signed-off-by: Sascha Grunert <sgrunert@suse.com>

commit 54ea46adf05267a659086fec63f1d3681ad4708b
Merge: b3729f8 0f63a9a
Author: Audrius Butkevicius <audrius.butkevicius@gmail.com>
Date:   Thu Aug 29 20:52:07 2019 +0100

    Merge pull request #857 from saschagrunert/takes-file-fish

    Add `TakesFile` to fish shell completion

commit 0f63a9ac5424ebae3d27514caf8377e1575c6095
Author: Sascha Grunert <sgrunert@suse.com>
Date:   Mon Aug 26 10:07:50 2019 +0200

    Update function alignment

    Signed-off-by: Sascha Grunert <sgrunert@suse.com>

commit fecd53d845f3b4ddfe3a7d8ae3ee4df3f58f985f
Author: Sascha Grunert <sgrunert@suse.com>
Date:   Mon Aug 26 08:46:55 2019 +0200

    Add type switch

    Signed-off-by: Sascha Grunert <sgrunert@suse.com>

commit ac18a87ed6bd1d5fd48fa96f00b5e3c084f38ebc
Author: Sascha Grunert <mail@saschagrunert.de>
Date:   Sun Aug 25 17:50:18 2019 +0200

    Removed GetTakesFile and stick to type assertions

    Signed-off-by: Sascha Grunert <mail@saschagrunert.de>

commit ed6f81caada02a1418fa9bdae4bd6a659925c2b9
Author: Sascha Grunert <sgrunert@suse.com>
Date:   Mon Aug 12 09:42:12 2019 +0200

    Add `TakesFile` to fish shell completion

    The new `TakesFile` flag will be now consumed by the fish shell
    completion generator.

    Signed-off-by: Sascha Grunert <sgrunert@suse.com>

commit b3729f86bfd7952d751784a63daaed6ffffe7174
Merge: 314ccb7 a9eeb49
Author: Lynn Cyrin (they/them) <lynn@textio.com>
Date:   Sat Aug 24 18:58:52 2019 -0700

    Merge pull request #876 from urfave/lynncyrin-patch-1

    Bump go version to 1.10 in readme

commit a9eeb49647069a71b48fbbe0c480935305f8290c
Merge: e68e53b 314ccb7
Author: Audrius Butkevicius <audrius.butkevicius@gmail.com>
Date:   Sun Aug 25 01:04:33 2019 +0100

    Merge branch 'master' into lynncyrin-patch-1

commit 314ccb7ccb295ab1675c74ca669d1e3b3bddcace
Merge: e25377e 368f79a
Author: Audrius Butkevicius <audrius.butkevicius@gmail.com>
Date:   Sun Aug 25 01:04:17 2019 +0100

    Merge pull request #860 from saschagrunert/takes-file-not-all

    Update `TakesFile` flag to apply only to supported flags

commit e68e53bb4c0e42db6048c5148257a7b8cd8627db
Author: Lynn Cyrin (they/them) <lynn@textio.com>
Date:   Sat Aug 24 14:44:56 2019 -0700

    Bump go version to 1.10 in readme

    Closes https://github.com/urfave/cli/issues/875

commit 368f79a0270c65245663b968646b2c72891776a0
Merge: a08ba2c e25377e
Author: Lynn Cyrin (they/them) <lynn@textio.com>
Date:   Sat Aug 24 14:34:15 2019 -0700

    Merge branch 'master' into takes-file-not-all

commit e25377e4649c5c676ef2584efa1e2c0a8a5e0f1f
Merge: 45f1959 62531f3
Author: Audrius Butkevicius <audrius.butkevicius@gmail.com>
Date:   Sat Aug 24 11:55:28 2019 +0100

    Merge pull request #873 from urfave/show-test-failures

    build: show failures when running tests

commit 62531f3dac71c68f8f3b94e2186440769185998b
Author: Audrius Butkevicius <audrius.butkevicius@gmail.com>
Date:   Sat Aug 24 11:34:03 2019 +0100

    Update build.go

commit 3a8dc8e059972b0468db0196087f55f7c69a62fe
Author: Lynn Cyrin <lynn@textio.com>
Date:   Sat Aug 24 03:05:45 2019 -0700

    Revert "check length"

    This reverts commit 8a9ec188d501c670a82907a09b83b13a4c81b70e.

commit a08ba2c92870aa981c8477d252872683cc77229a
Merge: fd74609 45f1959
Author: Sascha Grunert <sgrunert@suse.com>
Date:   Sat Aug 24 11:23:51 2019 +0200

    Merge branch 'master' into takes-file-not-all

commit cf3ec00901058cdd9361f61403dc50096cb86a9c
Merge: 8a9ec18 45f1959
Author: Lynn Cyrin (they/them) <lynn@textio.com>
Date:   Sat Aug 24 00:50:42 2019 -0700

    Merge branch 'master' into show-test-failures

commit 8a9ec188d501c670a82907a09b83b13a4c81b70e
Author: Lynn Cyrin <lynn@textio.com>
Date:   Sat Aug 24 00:49:29 2019 -0700

    check length

commit 8d2a0f8a160fc4cc25be12ef40e3210f1e2aacdc
Author: [[ BOT ]] Lynn Cyrin <lynncyrin@gmail.com>
Date:   Fri Aug 23 20:09:08 2019 -0700

    DRY

commit 45f1959f55aa1ef0605d6cc30ffb3b82bedcb47e
Merge: 022e81e 8a97e3d
Author: Audrius Butkevicius <audrius.butkevicius@gmail.com>
Date:   Fri Aug 23 22:51:39 2019 +0100

    Merge pull request #874 from saschagrunert/go-mod-cleanup

    Cleanup go modules

commit 8a97e3dc2350b95b14b0427fc2a6b98d6b228c1d
Author: Sascha Grunert <sgrunert@suse.com>
Date:   Fri Aug 23 10:28:32 2019 +0200

    Cleanup go modules

    These two dependencies are not really needed, which can be
    reproduced via:

    ```
    > export GO111MODULE=on && go mod tidy
    ```

    Signed-off-by: Sascha Grunert <sgrunert@suse.com>

commit d443828b9ee73cc029f87135a82e72ba2c28d990
Author: [[ BOT ]] Lynn Cyrin <lynncyrin@gmail.com>
Date:   Thu Aug 22 21:42:07 2019 -0700

    show test failures

commit 022e81efc4183243af85d00816526c5a010e2e06
Merge: 59786af 4d4274a
Author: Lynn Cyrin (they/them) <lynn@textio.com>
Date:   Sat Aug 17 11:24:05 2019 -0700

    Merge pull request #862 from russoj88/UpdateREADME_gopkg.in_v1

    Rewrite the "pinning to v1" section.

commit 4d4274aa0161635939ef3fe25748abb53536fc0e
Merge: 562b6a1 59786af
Author: russoj88 <russoj88@users.noreply.github.com>
Date:   Sat Aug 17 10:01:35 2019 -0700

    Merge branch 'master' into UpdateREADME_gopkg.in_v1

commit 59786afa53e17a83f0c9141ed01bb073262e5203
Merge: 0c1f99e 970eb0f
Author: Audrius Butkevicius <audrius.butkevicius@gmail.com>
Date:   Sat Aug 17 16:51:43 2019 +0100

    Merge pull request #868 from urfave/lynncyrin-patch-1

    Modernize readme

commit 970eb0f8229897a8ca5effcf2502e3d14a59e4da
Author: Lynn Cyrin (they/them) <lynn@textio.com>
Date:   Sat Aug 17 02:44:49 2019 -0700

    Modernize readme

    I assume that people no longer care about what the package was named many years ago

commit 562b6a192d71846bba9a045d698a3fee1fcdfbbe
Author: russoj88 <russoj88@gmail.com>
Date:   Thu Aug 15 12:30:29 2019 -0700

    Mimic v2 example code from above.

commit dd8123fa4a7750df9e44c2bffbaab563d5ee8d6f
Author: russoj88 <russoj88@gmail.com>
Date:   Wed Aug 14 11:20:09 2019 -0700

    Add "Using v1 releases" to table of contents.

commit 168eaa9c70f37ff1f1d793b0f96a0e9d2891ebb0
Author: russoj88 <russoj88@users.noreply.github.com>
Date:   Wed Aug 14 11:21:40 2019 -0700

    Update README.md

    Only instruct on right way to use library.

    Co-Authored-By: Lynn Cyrin (they/them) <lynncyrin@gmail.com>

commit 71139b548eea793dbd22c3dc03f6532212c02c12
Author: russoj88 <russoj88@users.noreply.github.com>
Date:   Wed Aug 14 11:20:58 2019 -0700

    Update README.md

    Include suggestion to put example in.

    Co-Authored-By: Lynn Cyrin (they/them) <lynncyrin@gmail.com>

commit 3d2ade07177d535ea376b04131ecb6e06db769c1
Author: russoj88 <russoj88@gmail.com>
Date:   Tue Aug 13 21:10:38 2019 -0700

    Rewrite the "pinning to v1" section.

commit fd746096e377d18091dd2f38b121ae01ba156f53
Author: Sascha Grunert <sgrunert@suse.com>
Date:   Tue Aug 13 09:43:57 2019 +0200

    Update `TakesFile` flag to apply only to supported flags

    Signed-off-by: Sascha Grunert <sgrunert@suse.com>

commit 0c1f99e6393d0d8a9c78243fe43a5137de3307f4
Merge: 355b586 fcab6dd
Author: Audrius Butkevicius <audrius.butkevicius@gmail.com>
Date:   Mon Aug 12 21:30:37 2019 +0100

    Merge pull request #856 from FaranIdo/master

    Add Subcommand fallback call to ExitErrHandler, fixing #816

commit fcab6ddee72e00f1a44ce185245bd6a78e480102
Author: FaranIdo <idoosbron@gmail.com>
Date:   Mon Aug 12 00:29:46 2019 +0300

    add missing ExitErrHandler in command + matching test, fixing #816

commit 355b586fd49ac100728c0f0e45a8c57cb08fbaad
Merge: 56b5de3 57056da
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Sat Aug 10 09:01:16 2019 +0000

    Merge pull request #848 from saschagrunert/fish-shell

    Add fish shell completion support

commit 57056da6c2ca7b5de5e9b837560ee38a0b49d2c2
Merge: 2c1daee 56b5de3
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Sat Aug 10 08:47:31 2019 +0000

    Merge branch 'master' into fish-shell

commit 56b5de3d1852a1b72d421069c87f21d079ab5cba
Merge: 496090a 8959a48
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Sat Aug 10 08:47:23 2019 +0000

    Merge pull request #851 from saschagrunert/takes-file

    Add `TakesFile` indicator to flag

commit 2c1daee2fed6922b418e172c90c12930f75f1ba5
Merge: aade7c0 496090a
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Fri Aug 9 17:21:24 2019 +0530

    Merge branch 'master' into fish-shell

commit 8959a488748d02ff21f503310eb2ce4efbb7907c
Merge: 0e9e49b 496090a
Author: Sascha Grunert <sgrunert@suse.com>
Date:   Fri Aug 9 13:48:36 2019 +0200

    Merge branch 'master' into takes-file

commit 496090ab389c31ca4d1c845d4ec89e15b0844bac
Merge: c0c2d4e ca9d32a
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Fri Aug 9 17:16:13 2019 +0530

    Merge pull request #847 from saschagrunert/remove-date-var

    Remove unused `Date` variable from `cliTemplate`

commit ca9d32a21a851bc5198c2b55dc3d47b681e89a45
Merge: 766dfbf c0c2d4e
Author: Audrius Butkevicius <audrius.butkevicius@gmail.com>
Date:   Fri Aug 9 12:38:50 2019 +0100

    Merge branch 'master' into remove-date-var

commit 0e9e49b074bdd24ab07ed7d9778a7f68822a3410
Author: Sascha Grunert <sgrunert@suse.com>
Date:   Fri Aug 9 09:05:55 2019 +0200

    Add `TakesFile` indicator to flag

    This new member of `Flag` indicates if the flag expects a file as input.
    This is especially useful for documentation and shell completion purposes.

    Signed-off-by: Sascha Grunert <sgrunert@suse.com>

commit aade7c0fbd20cf9874526f74403a8ac6a296a5d7
Author: Sascha Grunert <sgrunert@suse.com>
Date:   Thu Aug 8 15:50:36 2019 +0200

    Add fish shell completion support

    This commit adds a new method `ToFishCompletion` to the `*App` which can
    be used to generate a fish completion string for the application.

    Relates to: #351

    Signed-off-by: Sascha Grunert <sgrunert@suse.com>

commit c0c2d4e66efc7753d2a2943a0ac3c4a920cfd996
Merge: fe45689 d957956
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Fri Aug 9 10:34:28 2019 +0530

    Merge pull request #845 from urfave/lint-fixes

    linter fixes

commit 766dfbfd3d18dc9785eecc3be3fafc5f3b69955a
Author: Sascha Grunert <sgrunert@suse.com>
Date:   Thu Aug 8 14:04:21 2019 +0200

    Remove unused `Date` variable from `cliTemplate`

    Signed-off-by: Sascha Grunert <sgrunert@suse.com>

commit d957956061325f8245825abaca52cbec0680173e
Merge: e4434fb fe45689
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Thu Aug 8 14:44:02 2019 +0530

    Merge branch 'master' into lint-fixes

commit fe4568917daca08523c3774cdfd89be17454bc34
Merge: c199a8b a3cadfe
Author: Audrius Butkevicius <audrius.butkevicius@gmail.com>
Date:   Thu Aug 8 09:13:09 2019 +0100

    Merge pull request #735 from rliebz/combined

    Add app-wide support for combining short flags

commit e4434fb7dbe38c8dc7ebd21ff0a6ef262b12f810
Merge: 9ef7e4d c199a8b
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Thu Aug 8 13:36:30 2019 +0530

    Merge branch 'master' into lint-fixes

commit a3cadfe817c8bf0303ba53565b88e2e43cdf8a2f
Merge: 8a74d67 c199a8b
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Thu Aug 8 13:33:32 2019 +0530

    Merge branch 'master' into combined

commit c199a8b6b9ebd9d95aa9e362d8b3c3ae7e557450
Merge: 3b50590 edf6ebd
Author: Audrius Butkevicius <audrius.butkevicius@gmail.com>
Date:   Thu Aug 8 08:41:19 2019 +0100

    Merge pull request #830 from saschagrunert/docs-gen

    Add markdown and man page docs generation methods

commit edf6ebd2421a41a4023b54bd0fb1db8cfb7cfedb
Merge: ac194cb 3b50590
Author: Audrius Butkevicius <audrius.butkevicius@gmail.com>
Date:   Thu Aug 8 07:06:08 2019 +0100

    Merge branch 'master' into docs-gen

commit 3b50590e4bd4ccf5c6e0cf6d9537be1c3fda8643
Merge: d80c64f 6bf98b9
Author: Audrius Butkevicius <audrius.butkevicius@gmail.com>
Date:   Thu Aug 8 07:04:25 2019 +0100

    Merge pull request #846 from urfave/asahasrabuddhe-patch-1

    Update README.md

commit 8a74d67765ab121236b11e929a41c0fae813e7d5
Merge: 6afc652 d80c64f
Author: Audrius Butkevicius <audrius.butkevicius@gmail.com>
Date:   Thu Aug 8 07:03:49 2019 +0100

    Merge branch 'master' into combined

commit 6bf98b90c5f660d4bf141592c0b197644e1e4d44
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Wed Aug 7 21:00:07 2019 +0530

    Update README.md

    remove quotes around coverage badge

commit 9ef7e4dadaecad259e2768fcf2eb6eafbafed544
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Wed Aug 7 20:14:50 2019 +0530

    linter fixes
    code cleanup
    changing some test code to ensure uniformity

commit ac194cb636743193fe8ddede491dfd2cf12c228f
Author: Sascha Grunert <mail@saschagrunert.de>
Date:   Sat Aug 3 12:41:50 2019 +0200

    Add markdown and man page docs generation methods

    This adds two new methods to the `App` struct:

    - `ToMarkdown`: creates a markdown documentation string
    - `ToMan`: creates a man page string

    Signed-off-by: Sascha Grunert <mail@saschagrunert.de>

commit d80c64f442b46ecc937c60b2293a8cfc640d3930
Merge: 867675a 91f5368
Author: Audrius Butkevicius <audrius.butkevicius@gmail.com>
Date:   Wed Aug 7 12:10:34 2019 +0100

    Merge pull request #844 from urfave/asahasrabuddhe-patch-1

    Update README.md

commit 91f5368a1e07eb95deac6eef3c006dda910fc1d5
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Wed Aug 7 14:02:52 2019 +0530

    Update README.md

    add codecov.io badge

commit 867675a38b56c1fdf3dfa6f35b284fca484cf685
Merge: d9c6428 0133b13
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Wed Aug 7 13:58:51 2019 +0530

    Merge pull request #843 from lafriks/patch-1

    Support GoLang 1.10 to 1.12

commit 0133b13dfd4424949307b22fcb1e319f51bca9e0
Author: Lauris BH <lauris@nix.lv>
Date:   Wed Aug 7 11:21:31 2019 +0300

    Lower support to GoLang compiler version 1.10

commit 6acbc6f12acc80028ae4cde5dc31e5b6837e74d5
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Wed Aug 7 13:50:04 2019 +0530

    Update .travis.yml

    support go versions in line with go's release policy

commit 455782d2c3c1f33d8c73c33316259884dfdff2e2
Author: Lauris BH <lauris@nix.lv>
Date:   Wed Aug 7 11:06:15 2019 +0300

    Support also GoLang 1.11 compiler

commit d9c6428196e3a28efdabbffa79f39982d9a25d17
Merge: 1bf6f05 6514096
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Wed Aug 7 13:28:34 2019 +0530

    Merge pull request #836 from urfave/flag-type-generation-golang

    Flag Generation in the CLI

commit 65140966954bd7d284c37f8796f86c7701e218e9
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Wed Aug 7 12:38:17 2019 +0530

    update readme with correct error message, add 1.12 and 1.11 to travis

commit 6afc652b770b908ad311301863dd295a5165115d
Merge: f850d76 1bf6f05
Author: Robert Liebowitz <rliebz@gmail.com>
Date:   Tue Aug 6 22:33:49 2019 -0400

    Merge branch 'master' into combined

commit 1b78f71be98fee79e476731dc4631c716666bbd3
Merge: dfe5717 1bf6f05
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Wed Aug 7 01:54:44 2019 +0530

    Merge branch 'master' into flag-type-generation-golang

commit dfe5717101661b2f7bf86c77410c41260afd5c2b
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Wed Aug 7 01:51:02 2019 +0530

    update ci commands

commit 58b280a862d92fc4737676986300b8576e488079
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Wed Aug 7 01:50:50 2019 +0530

    move build.go to root

commit 2b6c861cfc535a27635fc3dad87653a190c6bc4b
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Wed Aug 7 01:46:22 2019 +0530

    remove unnecessary sprintf

commit d8aacf1d3e9e21cd36c204371af1bbf8299f3990
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Tue Aug 6 12:33:33 2019 +0530

    move packages slice to global scope

commit 1bf6f05d3e2e25cd6d232a598f1a6a7eaabb5313
Merge: 9be5040 0a157df
Author: Audrius Butkevicius <audrius.butkevicius@gmail.com>
Date:   Tue Aug 6 07:59:53 2019 +0100

    Merge pull request #808 from yogeshlonkar/master

    Add support for flags bash completion

commit e0957fbcc76df77d3cda93fb1e424dbde47c0d83
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Tue Aug 6 12:14:18 2019 +0530

    indenting fix

commit 0a157dfeca33909fa187e153f599c49acaaa4de3
Author: Yogesh Lonkar <lonkar.yogeshr@gmail.com>
Date:   Mon Aug 5 20:22:52 2019 +0200

    Fix unused regex

commit 3824f0df44006e2e58527e5484739df4e7b710c4
Author: Yogesh Lonkar <lonkar.yogeshr@gmail.com>
Date:   Mon Aug 5 20:18:08 2019 +0200

    Add additional test for log flag completion and comments

commit 4c057e9fc00d164040d9f66d91c1b05897b23f43
Author: Yogesh Lonkar <lonkar.yogeshr@gmail.com>
Date:   Mon Aug 5 17:07:46 2019 +0200

    Fix SC2199: Arrays implicitly concatenate in

commit fe064959fe2a38885481fd7b154c618b855915bf
Author: Yogesh Lonkar <lonkar.yogeshr@gmail.com>
Date:   Mon Aug 5 16:58:04 2019 +0200

    Fix review comments

commit f850d76bbf91d9b1fcd8cc6b854573d8c70d6731
Author: Robert Liebowitz <rliebz@gmail.com>
Date:   Mon Aug 5 07:05:07 2019 -0400

    Update README.md

    Co-Authored-By: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>

commit c1f38ba3b01e4b6c40741c3ba6c790dbc59e3599
Author: Robert Liebowitz <rliebz@gmail.com>
Date:   Mon Aug 5 06:16:30 2019 -0400

    Allow combining short flags globally

commit 8ade19f8e7a0f93b6b5d23966aba94ed4ed9d91d
Merge: dea0226 9be5040
Author: Yogesh Lonkar <lonkar.yogeshr@gmail.com>
Date:   Mon Aug 5 11:00:26 2019 +0200

    Merge branch 'master' into master

commit 9be5040535daed037fee5d19a373222634b3ecd2
Merge: d3b94bd d7880a3
Author: Lynn Cyrin (they/them) <lynn@textio.com>
Date:   Sun Aug 4 12:36:23 2019 -0700

    Merge pull request #823 from xordspar0/master

    Make the exit code example more clear

commit d7880a36fb1f2151ec7a15b5bf0789c65323dd55
Merge: 713970a d3b94bd
Author: Lynn Cyrin (they/them) <lynn@textio.com>
Date:   Sun Aug 4 12:30:28 2019 -0700

    Merge branch 'master' into master

commit 9e1f30cf0cf726e2a4f42ef61cceafe2e6e1d8b3
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Sun Aug 4 20:45:28 2019 +0530

    add latest assets file

commit 5eebaf73ea3d8b2eacf7716c430dedaf3cfb4a6d
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Sun Aug 4 20:44:15 2019 +0530

    add missing os package

commit b57e272ece85df07f02f162f38acc3d34c0144fd
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Sun Aug 4 20:33:21 2019 +0530

    add zero mod fs back and commit file with latest ts

commit b11f18a28c00119144058020bd344046eb360e06
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Sun Aug 4 20:29:53 2019 +0530

    fix spacing issue

commit 3221f975cd33cb5589d3b485f92f3ce201082d7a
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Sun Aug 4 20:23:32 2019 +0530

    fix tests

commit 39d6a675b490b06957e94cfcb44ff31013a4afbb
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Sun Aug 4 20:06:44 2019 +0530

    move entire build system to go

commit 537166788cf0a86d1789a044cb93a62dfce4c2e8
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Sun Aug 4 19:01:47 2019 +0530

    remove zero mod fs

commit d3b94bd54d97f53b49043b234f8aec682fe7a1e5
Merge: 52a0ed0 f819410
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Sun Aug 4 18:00:11 2019 +0530

    Merge pull request #837 from urfave/codeowners

    Use codeowners instead of maintainers

commit f8194103c737759df1e658ad5743da95457ebb7f
Merge: 570cd38 52a0ed0
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Sun Aug 4 17:52:42 2019 +0530

    Merge branch 'master' into codeowners

commit dea0226a550e10c2b54f53dbf525395795b5ed32
Merge: d623641 52a0ed0
Author: Yogesh Lonkar <lonkar.yogeshr@gmail.com>
Date:   Sun Aug 4 10:38:56 2019 +0200

    Merge branch 'master' into master

commit c7ff356699034d0aee69bdca22ff881c374b3eaa
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Sun Aug 4 12:26:48 2019 +0530

    fix travis build

commit ba222c12b3c0a3e3589f4b062ef6809550c6e821
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Sun Aug 4 12:22:45 2019 +0530

    add new generation logic to travis

commit a9d580f382bb13d8f90c57083506845431b1c495
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Sun Aug 4 12:17:27 2019 +0530

    remove legacy version check code

commit d335fa9df122638b384426b39ef8709debbd43bc
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Sun Aug 4 12:16:07 2019 +0530

    update appveyor to go 1.11, add support for code coverage generation in tests

commit 90e2046d5a44081f508eb0884a3ed2650b398e9d
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Sun Aug 4 11:09:34 2019 +0530

    update app name and remove version

commit 61930a5ca5b32c2dfe2982a1518ee0cdd1fb1d6e
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Sun Aug 4 11:06:19 2019 +0530

    generate test with go generate

commit f5fc4538c9c0235e7a6e450b4f24641046f7b4c3
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Sun Aug 4 11:05:50 2019 +0530

    remove redundant go generate from altsrc
    update go generate in cli package to generate both files
    regeneration test

commit c0737ba6ef7134960b1c61b5488f2b51df55bebe
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Sun Aug 4 11:04:23 2019 +0530

    indentation fixes in template
    regeneration test

commit d076f305e7b09b8969d9eb9bd2e474858cca820a
Merge: f56b636 6f3fcb7
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Sun Aug 4 10:29:34 2019 +0530

    Merge branch 'flag-type-generation-golang' of https://github.com/urfave/cli into flag-type-generation-golang

commit f56b63648770b5ad782f07254b588e441700fc5d
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Sun Aug 4 10:28:08 2019 +0530

    move around code
    change package to flag-gen to avoid conflict with flag-generator binary
    test code generation

commit 0739dba3535ee391017d18aeac9cc801c095110a
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Sun Aug 4 10:05:44 2019 +0530

    change structure to embed source json and template files
    restructure code to have defaults in place of choices

commit fb0e18c54eed5dd0ce512a29880b3636d1f4f363
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Sun Aug 4 08:45:29 2019 +0530

    rename utility from fg > flag-generator

commit 52a0ed00f0b134b35829538bdcabbe87858d0460
Merge: 3d3b421 eac703f
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Sun Aug 4 08:15:00 2019 +0530

    Merge pull request #774 from whereswaldon/patch-1

    Clarify that altsrc supports both TOML and JSON

commit eac703fc726c01c0cf64f85a978bac86b9857629
Merge: 30deb3d 3d3b421
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Sun Aug 4 08:12:24 2019 +0530

    Merge branch 'master' into patch-1

commit 3d3b42193ac379fd1541a88dca07ccc3762ac0fd
Merge: 8e151c8 d2b034e
Author: Lynn Cyrin (they/them) <lynn@textio.com>
Date:   Sat Aug 3 19:37:52 2019 -0700

    Merge pull request #829 from urfave/lynncyrin-patch-2

    Release 1.21.0

commit 30deb3dbc05678a9221dd400d8ed36d4712d5149
Merge: 24c4f51 8e151c8
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Sun Aug 4 08:04:13 2019 +0530

    Merge branch 'master' into patch-1

commit 570cd3878d7ce57dd96e178698eb0cad02a90c5c
Author: [[ BOT ]] Lynn Cyrin <lynncyrin@gmail.com>
Date:   Sat Aug 3 10:26:07 2019 -0700

    update contributing docs

commit e652d609aa980b12c9e1d5db5264a3df7bd22389
Author: [[ BOT ]] Lynn Cyrin <lynncyrin@gmail.com>
Date:   Sat Aug 3 10:23:29 2019 -0700

    use codeowners instead of maintainers

commit 6f3fcb7b620d35d9d26db06a431e6b3a22afd942
Merge: 7e6476f 8e151c8
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Sat Aug 3 22:49:24 2019 +0530

    Merge branch 'master' into flag-type-generation-golang

commit 7e6476fec8478030c024cd63921fcb10ebf09f89
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Sat Aug 3 22:32:36 2019 +0530

    update go generate command
    test file generation

commit fd9e6ff6e751db174dd00401937b03a0342b0b86
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Sat Aug 3 22:16:25 2019 +0530

    updated flag types generated courtesy fg cli

commit 2f3170a98af23bef65244a5ed7b803e169f70062
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Sat Aug 3 22:15:43 2019 +0530

    add explicit true/false choices for value and dest keys due to go default false for bool types

commit a00c7b530e7855ac67991d0339761bcab363a53d
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Sat Aug 3 22:14:58 2019 +0530

    finish generation of flag types for altsrc package
    rename package to fg (flag generator)

commit 2d93e779d6f0f6573f8ba955510d27945e0977ad
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Sat Aug 3 21:48:48 2019 +0530

    finish generation of flag types for cli package

commit ef103f494d01089891995118a85e70ffc42b822a
Author: mingrammer <mingrammer@gmail.com>
Date:   Thu Mar 7 00:04:18 2019 +0900

    get latest changes from master

commit 03832a467c8f5f31b40d123a7840744f70ea277a
Author: mingrammer <mingrammer@gmail.com>
Date:   Wed Mar 6 23:51:22 2019 +0900

    Fix the unaligned indents for the commands that have no categories

commit 713970aac436001cc266cb5f83016a752844d12e
Merge: 781e756 8e151c8
Author: Lynn Cyrin (they/them) <lynn@textio.com>
Date:   Sat Aug 3 09:36:27 2019 -0700

    Merge branch 'master' into master

commit d2b034e2a9e4d8f873d2c506b9a26aa865a67d0a
Merge: f8816ec 8e151c8
Author: Lynn Cyrin (they/them) <lynn@textio.com>
Date:   Sat Aug 3 09:06:47 2019 -0700

    Merge branch 'master' into lynncyrin-patch-2

commit d6236417c777dfc57f56c9914707d8db12ff804c
Merge: aa4ff57 8e151c8
Author: Yogesh Lonkar <lonkar.yogeshr@gmail.com>
Date:   Sat Aug 3 15:52:08 2019 +0200

    Merge branch 'master' into master

commit 8e151c8594af5ddf6fbec630b617c6c4c5f43876
Merge: bbaa765 adeed0e
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Sat Aug 3 18:04:31 2019 +0530

    Merge pull request #831 from saschagrunert/go-modules

    Add go module support

commit 24c4f519a3389fb3ad63d0f45e43ea592dd16072
Merge: 40cfbc9 bbaa765
Author: Audrius Butkevicius <audrius.butkevicius@gmail.com>
Date:   Sat Aug 3 13:25:34 2019 +0100

    Merge branch 'master' into patch-1

commit adeed0eda4d309a636f419b88fcc7c035d30f6e7
Author: Sascha Grunert <mail@saschagrunert.de>
Date:   Sat Aug 3 12:55:06 2019 +0200

    Add go module support

    This adds a go.{mod,sum} file to official support go modules.

    Signed-off-by: Sascha Grunert <mail@saschagrunert.de>

commit bbaa765156e4b34992f75584a78467598600e69b
Merge: 10d8ad3 3dcb076
Author: Audrius Butkevicius <audrius.butkevicius@gmail.com>
Date:   Sat Aug 3 11:02:34 2019 +0100

    Merge pull request #773 from teresy/redundant-nil-check-slice

    Remove redundant nil checks

commit 3dcb076b298108a9ba0fd39596978f6da9093aa5
Merge: 2000447 10d8ad3
Author: Lynn Cyrin (they/them) <lynn@textio.com>
Date:   Sat Aug 3 02:05:33 2019 -0700

    Merge branch 'master' into redundant-nil-check-slice

commit 10d8ad36406da0ef101f31ede2502f88317ebf94
Merge: f68a516 d5d8dc4
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Sat Aug 3 08:47:32 2019 +0530

    Merge pull request #806 from mingrammer/fix-help-indentation

    Fix the unaligned indents for the command help messages

commit d5d8dc498effab61a8488a1725bc708097bd78df
Merge: 5496dbc f68a516
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Sat Aug 3 08:37:34 2019 +0530

    Merge branch 'master' into fix-help-indentation

commit f68a5168a927b93f189678b2875ed94aed850de7
Merge: cae12a4 41eafce
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Sat Aug 3 08:12:05 2019 +0530

    Merge pull request #828 from urfave/lynncyrin-patch-1

    Update maintainers for current reality

commit f8816ecf747a21edff96f8e36cf07a4685c5739d
Author: Lynn Cyrin (they/them) <lynn@textio.com>
Date:   Fri Aug 2 19:30:41 2019 -0700

    Update CHANGELOG.md

commit 1696ccbadaf641f1bbb0f7c2283c0922179604bf
Author: Lynn Cyrin <lynn@textio.com>
Date:   Fri Aug 2 18:26:41 2019 -0700

    Update CHANGELOG.md

commit 5496dbc40cd6428c3179c8776737544ce3fa9b4e
Merge: 0b3b256 cae12a4
Author: Lynn Cyrin <lynn@textio.com>
Date:   Fri Aug 2 18:14:50 2019 -0700

    Merge branch 'master' into fix-help-indentation

commit 41eafce22d4e88eebdfa1f4bf10e6c74548116a4
Author: Lynn Cyrin <lynn@textio.com>
Date:   Fri Aug 2 18:06:15 2019 -0700

    Update maintainers for current reality

commit aa4ff57a0e8930232e1728564bc72782e45cb147
Merge: 2a0ee5c cae12a4
Author: Yogesh Lonkar <lonkar.yogeshr@gmail.com>
Date:   Fri Aug 2 22:03:55 2019 +0200

    Merge branch 'master' into master

commit 781e756cdf83e601b04ad8e49ed5b80d93a5004b
Author: Jordan Christiansen <Jordan.Christiansen@target.com>
Date:   Fri Aug 2 14:28:57 2019 -0500

    Make exit code example more clear

    The purpose of this example is to show that you can exit with an error
    code if a flag is unspecified, but with the code as it is, the only way
    to cause a non-zero exit is by adding the flag `--ginger-crouton=false`,
    which is not explained in the example.

    In this new version of the example, running the command with no flag
    will exit with an error, and running it with the flag will exit
    normally.

commit cae12a4069d85c4918fa94df4da7ee098d12a858
Merge: abd410e a09cfcf
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Fri Aug 2 22:52:32 2019 +0530

    Merge pull request #819 from lynncyrin/required-flags-take-2

    Required flags

commit a09cfcf3516da0d9659230d7281aa72506334442
Merge: 968c227 abd410e
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Fri Aug 2 22:49:29 2019 +0530

    Merge branch 'master' into required-flags-take-2

commit abd410e066519d6e43e4d172fe7c51294dab91b1
Merge: 52c86a8 106d25f
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Fri Aug 2 22:49:09 2019 +0530

    Merge pull request #788 from benzvan/master

    adds test coverage to context

commit 968c2273fe83791c1d1785e3806b045846a6c1ca
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Aug 1 23:27:34 2019 -0700

    remove help assertion stuff

commit ce033ca1b590ada1cdc62db08a335795fafe65e8
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Aug 1 23:26:43 2019 -0700

    add env var tests

commit 7d3cf36ec858a5456ce48c3a5be515ae958b8ba5
Author: Lynn Cyrin <lynncyrin@gmail.com>
Date:   Thu Aug 1 22:54:15 2019 -0700

    Update command.go

commit 88a6aed6d0e056c17015f947cc20b77052ec6f0d
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Aug 1 22:52:21 2019 -0700

    add environment variable support :tada:

commit 582a4f905b4c83c18bbb568d447ad1242fe77c78
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Aug 1 22:10:18 2019 -0700

    cleanup some issues with error display

commit f2e342d65928bc95e34289f73bff7abbe4ce6b70
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Aug 1 21:48:52 2019 -0700

    update comments

commit 95d3b22911e41be740351c2d6b1d8a9306e38712
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Aug 1 21:46:56 2019 -0700

    rename cases

commit 6cc34c0323f3d0d7406d5f76bccc2f5a0562cac7
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Aug 1 21:45:11 2019 -0700

    more test cases

commit e2fd6db4769160246689d5c0be80e8bbc2604309
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Aug 1 21:35:15 2019 -0700

    add typed error assertions

commit ab2c3348fed019a1438ae1221064234d4a3dace2
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Aug 1 20:58:08 2019 -0700

    more test cases

commit 8094f7d075e0034077641fb3489085f70d23b395
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Aug 1 20:39:37 2019 -0700

    expand test cases

commit 5b3dd031cfc275954575eb85eaff75152fb26267
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Aug 1 20:35:23 2019 -0700

    add test cases

commit e1512f186ef2b8f7065bc6796774eaaa365cce7a
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Aug 1 20:30:43 2019 -0700

    update test names

commit 579ec2d0c7c01e008be6f91fba99fa137ee4ec9d
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Aug 1 20:27:51 2019 -0700

    update test to reflect app flag usage

commit c73231b30c62ab8af9fbac6a86f8ef1c93f627a8
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Aug 1 19:57:14 2019 -0700

    remove unused thing

commit f8032f16b7134c76dd63dd97cc44537fd99c23cc
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Aug 1 19:54:57 2019 -0700

    remove showFlagError, we can use the help printer assertion to accomplish the same goal

commit c56701e934e8062a87f1bcda9bfd05d1b00e4725
Author: Lynn Cyrin <lynn@textio.com>
Date:   Sun Jul 28 22:45:43 2019 -0700

    Revert "reset generated flags changes"

    This reverts commit f140e3e816ee0c7747035cbc56c16c8c5cc9b16b.

commit f140e3e816ee0c7747035cbc56c16c8c5cc9b16b
Author: Lynn Cyrin <lynn@textio.com>
Date:   Sun Jul 28 22:34:07 2019 -0700

    reset generated flags changes

commit 3dcc8279ceed93b9e64ecf719c08c777e577d99f
Author: Lynn Cyrin <lynn@textio.com>
Date:   Sun Jul 28 22:19:35 2019 -0700

    cleanup tests, check required flags in more places

commit 2a0ee5c81d4ee64c013d2459f30d4a2b05f743d5
Author: Yogesh Lonkar <lonkar.yogeshr@gmail.com>
Date:   Wed Jul 24 16:08:47 2019 +0200

    Fix issue with source command completion

    Avoid competion for bash builtin `source` and fallback to default implementation as it throws below error
    ```
    -bash: source: --: invalid option
    source: usage: source filename [arguments]
    ```

commit 5495bd6af4d5d0300e529324a7e0de5038b085bd
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Jul 18 00:52:24 2019 -0700

    remove unused code

commit c178a8dcf968430c6f4cae37bdc15f806e2dac04
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Jul 18 00:51:16 2019 -0700

    reduce diff

commit d84d379434df58f8e9e5b8b289b5bf77d5433dd2
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Jul 18 00:48:09 2019 -0700

    show errors

commit 1264b13d76cf477410725938fb21ebd4c2bd3f54
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Jul 18 00:47:18 2019 -0700

    cleanup subcommand and specs

commit 142b8e4defe86538d73bfba1e1f815407c78674d
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Jul 18 00:20:32 2019 -0700

    add subcommand

commit e171c9dabebca8045e908f273e5a988912367a91
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Jul 18 00:09:07 2019 -0700

    wording shift

commit f804c48e2a7a71400af8727b589b3b4aeab190e9
Author: Lynn Cyrin <lynncyrin@gmail.com>
Date:   Wed Jul 17 00:25:13 2019 -0700

    copy update

commit 8b32c1fad287b3678c78d62cbc321f7850059ae7
Author: Lynn Cyrin <lynn@textio.com>
Date:   Wed Jul 17 00:20:44 2019 -0700

    use strings.Join

commit 3177de170d4c128ed362158c04a983b3af77a302
Author: Lynn Cyrin <lynn@textio.com>
Date:   Wed Jul 17 00:16:40 2019 -0700

    add handling for multiple required flags

commit c9eb89bceabe294902ad91fa793922fd20772488
Author: Lynn Cyrin <lynn@textio.com>
Date:   Sun Jul 14 21:00:16 2019 -0700

    visually shorten logic

commit d5396ef5dbedc297fb566d17c6ba62b2822a2be5
Author: Lynn Cyrin <lynn@textio.com>
Date:   Sat Jul 13 14:02:45 2019 -0700

    docs

commit ceb9909757ac007a09e15e7021b22795f3ec287b
Author: Lynn Cyrin <lynn@textio.com>
Date:   Sat Jul 13 13:59:29 2019 -0700

    tabs

commit a127d8c48ebb99ff05965d67aed806ce5748973f
Author: Lynn Cyrin <lynn@textio.com>
Date:   Sat Jul 13 13:57:06 2019 -0700

    update tests

commit 24df9dafdd62e72d32b71a08f7728bb9fe6c663c
Author: Lynn Cyrin <lynn@textio.com>
Date:   Sat Jul 13 03:51:26 2019 -0700

    fill out test cases

commit 9704849ffbf9b77b09774764ab8596ce02a1dd8d
Author: Lynn Cyrin <lynn@textio.com>
Date:   Sat Jul 13 03:44:39 2019 -0700

    add update integration with the help output

commit 6a2109116e489507e303a3fa956b960fe6066ae9
Author: Lynn Cyrin <lynn@textio.com>
Date:   Sat Jul 13 01:26:47 2019 -0700

    update tests

commit 233b5c2a6cb42c46e3e962a4125319a15e745ab7
Author: Lynn Cyrin <lynn@textio.com>
Date:   Sat Jul 13 01:03:46 2019 -0700

    quote the flag name

commit 10af41d32ff1dfd3f62bb70e53726b771f76bb28
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Jul 11 21:53:10 2019 -0700

    backwards compatible RequiredFlag implementation

commit 3e160ccf37e3e09189178f63c9bd4b8befec11fe
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Jul 11 21:28:09 2019 -0700

    ./generate-flag-types cli -i flag-types.json -o flag_generated.go

commit bc0f9fb0e8fd95dda555001a2fbae229f02ce494
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Jul 11 20:47:47 2019 -0700

    remove manual isRequired funcs

commit 5abc31c14e8843b813e222f539a49b2eca60cb8f
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Jul 11 20:46:22 2019 -0700

    add IsRequired to generator

commit e245e76a10f9001744e5d02b1105d7c5cebe2a36
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Jul 11 20:44:41 2019 -0700

    add required attr to generator

commit 10294e2d7cc47079e42e88db26049e614f258fad
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Jul 11 20:34:17 2019 -0700

    update func name

commit deee3b6065304f0bca8cad772dee9eaba16d603b
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Jul 11 20:32:42 2019 -0700

    reduce diff

commit 8f360b2d36db1b876c6920fbdd3d56abf4feed93
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Jul 11 20:32:15 2019 -0700

    reduce diff

commit 96fa097b83eaec2163ecb29973f445a3d78891e3
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Jul 11 20:28:29 2019 -0700

    reduce diff

commit 212e0e65ce0f50db5e753ed22814b004fb5cd7c9
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Jul 11 20:25:52 2019 -0700

    update Run command

commit 109ac32041ad72abf785d40d1721311bb240fd78
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Jul 11 20:22:16 2019 -0700

    reduce diff

commit 01e9d26546bc273f6c71b56a8adc0e08988c21dc
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Jul 11 20:21:05 2019 -0700

    merge in test file

commit 5f76a9b75681025f4d78d1f641adf600701ea2f1
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Jul 11 20:19:42 2019 -0700

    reduce diff

commit 398b733d0b8b41379c3724df33551a6a1c263027
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Jul 11 20:18:52 2019 -0700

    reduce diff???

commit 5f4b0e80207b475f26b6febc70db2c78022ec7b4
Merge: ea174d1 52c86a8
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Jul 11 20:07:55 2019 -0700

    Merge branch 'master' into required_flags

commit 200044742e278406fd9e87a7c7fd2479a0d625ef
Merge: 774e1b1 52c86a8
Author: Audrius Butkevicius <audrius.butkevicius@gmail.com>
Date:   Fri Jun 28 07:55:04 2019 +0100

    Merge branch 'master' into redundant-nil-check-slice

commit 106d25ff72a4dbb5781e1929dfe95bc70ef740cc
Author: Ben Zvan <ben.zvan@target.com>
Date:   Wed Jun 26 09:41:11 2019 -0500

    Revert "Created using Colaboratory"

    This reverts commit 20ec54570cf56f7c6123c2902e63c6faa4300d28.
    This commit was randomly created here when I connected to colaboratory

commit 20ec54570cf56f7c6123c2902e63c6faa4300d28
Author: Ben Zvan <ben@zvan.net>
Date:   Tue Jun 25 18:47:58 2019 -0500

    Created using Colaboratory

commit a8299306f30db736e6a5a4a6eac85825b6e83acc
Merge: e045935 52c86a8
Author: Ben Zvan <ben@zvan.net>
Date:   Fri Jun 14 10:14:07 2019 -0500

    Merge branch 'master' into master

commit 7cb10cb4b3d0faddccd46941ede6003fc9cdcfb0
Author: Yogesh Lonkar <ylonkar@whitehedge.com>
Date:   Thu Apr 11 10:57:58 2019 +0530

    Don't complete hidden flags

commit 91d52d2292133c36191e8051896b0fc5ededd903
Author: Yogesh Lonkar <lonkar.yogeshr@gmail.com>
Date:   Thu Mar 21 13:01:48 2019 +0530

    Add default completion on commands, test cases, refactor code

commit 66e190a7cf7f1539e5cd66019f57f201d83314b3
Author: Yogesh Lonkar <lonkar.yogeshr@gmail.com>
Date:   Wed Mar 20 21:34:56 2019 +0530

    Fix duplicate completion of existing flag

commit 0d8957bf65e4ae51c190ffb97dcb9a18cd8fce2c
Author: Yogesh Lonkar <lonkar.yogeshr@gmail.com>
Date:   Wed Mar 20 20:28:51 2019 +0530

    Add bash completion support for flags

commit 0b3b256c794f236dd4d410758eaa5d9b02eac307
Author: mingrammer <mingrammer@gmail.com>
Date:   Thu Mar 7 00:04:18 2019 +0900

    Update README.md

commit 0c8c2486e54b85f8786becda6fdf646b87784f1f
Author: mingrammer <mingrammer@gmail.com>
Date:   Wed Mar 6 23:51:22 2019 +0900

    Fix the unaligned indents for the commands that have no categories

commit 52c86a894a09057f92a4e67532043ebd26b35a70
Merge: dddd04b d759f47
Author: Audrius Butkevicius <audrius.butkevicius@gmail.com>
Date:   Sun Feb 3 18:40:40 2019 +0000

    Merge pull request #766 from agis/patch-1

    Fix README typo

commit 774e1b10e01c5fb74ca58861102a4f41a3238fd7
Merge: cd688af dddd04b
Author: Audrius Butkevicius <audrius.butkevicius@gmail.com>
Date:   Sun Feb 3 18:39:49 2019 +0000

    Merge branch 'master' into redundant-nil-check-slice

commit dddd04b7dba58e77e0ed62426761a1e3d355a736
Merge: e057e3e 6fff1f3
Author: Audrius Butkevicius <audrius.butkevicius@gmail.com>
Date:   Sun Feb 3 18:37:18 2019 +0000

    Merge pull request #798 from Quasilyte/patch-1

    use type switch instead of if/else

commit 6fff1f3e6570f7760afc4df91346497b01e53a53
Author: Iskander (Alex) Sharipov <quasilyte@gmail.com>
Date:   Tue Jan 29 22:51:02 2019 +0300

    use type switch instead of if/else

    This reduces the syntax noise of the code by
    removing excessive type assertions.

    Signed-off-by: Iskander Sharipov <quasilyte@gmail.com>

commit e0459356a3608a2c4af7457b12e3f1775207bc38
Author: Ben Zvan <benjamin.zvan@target.com>
Date:   Wed Dec 26 12:48:12 2018 -0600

    go fmt

commit 248cb98d44b4318cc31315139befc5b400237841
Author: Ben Zvan <benjamin.zvan@target.com>
Date:   Wed Dec 26 12:41:27 2018 -0600

    adds test coverage to context

commit e057e3e5359282a3d78887b19a0646db1f3ea062
Merge: d774452 59a2225
Author: Audrius Butkevicius <audrius.butkevicius@gmail.com>
Date:   Mon Oct 29 21:32:00 2018 +0000

    Merge pull request #776 from gliptak/patch-2

    Bring Go version current

commit 59a22258a2d7d3ca6bba40a626d87149b4b5c9f1
Merge: fcd7da0 d774452
Author: Audrius Butkevicius <audrius.butkevicius@gmail.com>
Date:   Mon Oct 29 21:19:45 2018 +0000

    Merge branch 'master' into patch-2

commit d774452d4e5efd61dcc95e124ebad5189039ead9
Merge: 418b7a2 a9efc56
Author: Audrius Butkevicius <audrius.butkevicius@gmail.com>
Date:   Mon Oct 29 21:18:40 2018 +0000

    Merge pull request #775 from gliptak/patch-1

    Correct typo

commit fcd7da02eea455c1d3c4c3dd7d74802603b2e07c
Author: Gábor Lipták <gliptak@gmail.com>
Date:   Thu Oct 18 21:00:02 2018 -0400

    Bring Go version current

commit a9efc56d08f7f8386f50583d8179562a59746ba9
Author: Gábor Lipták <gliptak@gmail.com>
Date:   Thu Oct 18 20:56:13 2018 -0400

    Correct typo

commit 40cfbc9ce877b14656384a95ec748aa554068b90
Author: Christopher Waldon <christopher.waldon.dev@gmail.com>
Date:   Fri Oct 12 11:30:46 2018 -0400

    Clarify that altsrc supports both TOML and JSON

commit cd688af3354fae87b25d8a24c1c3c02663b969e1
Author: teresy <hi.teresy@gmail.com>
Date:   Wed Oct 10 14:54:48 2018 -0400

    Remove redundant nil checks

commit d759f47005028b76d78efc50ef0dff81a43fc691
Author: Agis Anastasopoulos <827224+agis@users.noreply.github.com>
Date:   Tue Aug 21 11:19:37 2018 +0300

    Fix README typo

commit 418b7a2db9b107e82d8be25966fd93aae344b447
Merge: 870e234 36debd7
Author: Audrius Butkevicius <audrius.butkevicius@gmail.com>
Date:   Tue Aug 21 07:40:27 2018 +0100

    Merge pull request #758 from vrothberg/fix-short-opts-parsing

    short opt handling: fix parsing

commit 36debd717a2cba555380a92e0d872056f7fe88ec
Author: Valentin Rothberg <vrothberg@suse.com>
Date:   Tue Aug 21 08:33:42 2018 +0200

    fix `go vet` warning

    command_test.go:342:3 value declared but not used

    Signed-off-by: Valentin Rothberg <vrothberg@suse.com>

commit 3ffd92f2fd4176023b4e5141851f42dbdea7dfee
Author: Valentin Rothberg <vrothberg@suse.com>
Date:   Thu Jun 28 16:41:02 2018 +0200

    short opt handling: fix parsing

    Only split a given string (e.g., "-abc") into short options (e.g., "-a",
    "-b", "-c") if all those are flags.  To further avoid mistakenly
    transform common arguments, catch "flag provided but not defined" errors
    to iteratively transform short options.

    Signed-off-by: Valentin Rothberg <vrothberg@suse.com>
    Fixes: https://github.com/projectatomic/libpod/issues/714

commit 870e234c3ffb6d5ee9a645d07e13fc6a3a313ba4
Merge: 3af4543 f1fafe3
Author: Dan Buch <dan@meatballhat.com>
Date:   Sun Feb 25 22:02:53 2018 -0500

    Merge pull request #598 from urfave/backport-json-support

    Backport JSON InputSource to v1

commit f1fafe39c62aff7e72b6b21997861644fed40334
Merge: d8e52aa 3af4543
Author: Dan Buch <dan@meatballhat.com>
Date:   Sun Feb 25 16:09:48 2018 -0500

    Merge branch 'master' into backport-json-support

commit 3af4543245db90394ae01680f0b94439c6fbf8be
Merge: a70b1ef 0db3183
Author: Dan Buch <dan@meatballhat.com>
Date:   Sun Feb 25 16:09:04 2018 -0500

    Merge pull request #498 from urfave/merging-jereksel-zsh

    Merging #489 (plus hack)

commit 0db3183d652b2cfd487ced2f2b7fac031e6e6890
Merge: c677ece a70b1ef
Author: Dan Buch <dan@meatballhat.com>
Date:   Sat Feb 24 22:02:40 2018 -0500

    Merge branch 'master' into merging-jereksel-zsh

commit a70b1ef950e3fbf69dfcd686fcfe56e2129335a2
Merge: 676b84e 5cff56e
Author: Dan Buch <dan@meatballhat.com>
Date:   Sat Feb 24 22:02:19 2018 -0500

    Merge pull request #681 from urfave/check-run-error-in-readme

    Update README examples to check for errors

commit c677ecedcf13994c0080739b0e3dc5f0ece5f70a
Merge: 4123f22 676b84e
Author: Dan Buch <dan@meatballhat.com>
Date:   Sat Feb 24 21:58:26 2018 -0500

    Merge branch 'master' into merging-jereksel-zsh

commit 5cff56ee33913708394935abb2923630b2bc6d8c
Merge: 42b4c91 676b84e
Author: Dan Buch <dan@meatballhat.com>
Date:   Sat Feb 24 21:54:06 2018 -0500

    Merge branch 'master' into check-run-error-in-readme

commit 676b84e1d5e491aafa569bb79c8f765b605b4caa
Merge: c97f3ca 38b23bf
Author: Jesse Szwedko <jesse.szwedko@gmail.com>
Date:   Tue Feb 20 21:16:31 2018 -0800

    Merge pull request #715 from urfave/maintainers-notice

    Adjust contribution and maintainer prose per current reality

commit 38b23bf2e576b8b33c70c21ccabc585b3cecded5
Author: Dan Buch <dan@meatballhat.com>
Date:   Tue Feb 20 12:40:43 2018 -0500

    Adjust contribution and maintainer prose per current reality

commit 42b4c91dc354cc2875a85197292411ed36961e83
Merge: d479aa8 c97f3ca
Author: Dan Buch <dan@meatballhat.com>
Date:   Tue Feb 13 15:27:04 2018 -0500

    Merge branch 'master' into check-run-error-in-readme

commit c97f3ca015c907a24d52ad44d7e00fdb69ed037f
Merge: b5b6d97 7fb008f
Author: Jesse Szwedko <jesse.szwedko@gmail.com>
Date:   Sat Feb 10 18:18:39 2018 -0800

    Merge pull request #712 from windler/fix_args_reorder

    Fix args reordering when bool flags are present

commit 7fb008fdf7ab68e817df0c9e0b0ab50c49e47354
Author: Nico Windler <nico.windler@gmail.com>
Date:   Sat Feb 10 13:35:23 2018 +0100

    Fix args reordering when bool flags are present

commit b5b6d97d02a5b9dc71be14be5ace07dae5e84412
Merge: 4853ba6 666e931
Author: Jesse Szwedko <jesse.szwedko@gmail.com>
Date:   Fri Feb 2 13:13:18 2018 -0800

    Merge pull request #704 from dolmen/replace-unneeded-Sprintf

    Fix unnecessary uses of Sprintf

commit 666e9318bc34cc7642391d2038c7c9d9ca1f6d9c
Author: Olivier Mengué <dolmen@cpan.org>
Date:   Fri Jan 26 21:14:34 2018 +0100

    Fix unnecessary uses of Sprintf

    - use strconv directly
    - use concatenation for "%s%s"

commit 4853ba6fa0eee186a3141fe997adb50453ddda17
Merge: f037903 8585d88
Author: Jesse Szwedko <jesse.szwedko@gmail.com>
Date:   Sat Jan 6 11:10:48 2018 -0800

    Merge pull request #697 from urfave/fix-skip-flag-parsing

    Fix regression of SkipFlagParsing behavior

commit 8585d8868f36c5e04ece73d66f2f13a992ee1fb8
Author: Jesse Szwedko <jesse.szwedko@gmail.com>
Date:   Fri Dec 29 13:38:18 2017 -0500

    Fix regression of SkipFlagParsing behavior

    Introduced by e8da5467bbdf86469510e6ba5f0515e2ac10dca7

    Was mistakenly prepending the command name.

commit f037903559c5becbf40479e5c3a127393b3ebe15
Merge: 36294c1 1dffe79
Author: Jesse Szwedko <jesse.szwedko@gmail.com>
Date:   Tue Dec 12 08:34:29 2017 -0800

    Merge pull request #691 from urfave/refactor-686

    Refactor flag handling logic

commit 1dffe796cad1fad1d62c16ecebe360f4aef4b119
Merge: 4d7b336 36294c1
Author: Jesse Szwedko <jesse.szwedko@gmail.com>
Date:   Mon Dec 11 18:51:46 2017 -0800

    Merge branch 'master' into refactor-686

commit 4d7b336c347b5a8f8bdcbb66e8ce3ca17533327b
Author: Jesse Szwedko <jesse.szwedko@gmail.com>
Date:   Mon Dec 4 09:23:40 2017 -0800

    Add tests for flag reordering

commit 36294c11bcb6e92429d9c6b61c5b506f1136a59c
Merge: d8f80f8 c315e9b
Author: Jesse Szwedko <jesse.szwedko@gmail.com>
Date:   Sun Dec 3 13:42:37 2017 -0800

    Merge pull request #690 from gliptak/patch-1

    Correct go vet for Go tip

commit e8da5467bbdf86469510e6ba5f0515e2ac10dca7
Author: Jesse Szwedko <jesse.szwedko@gmail.com>
Date:   Sun Dec 3 13:38:50 2017 -0800

    Refactor flag handling logic

    Refactor logic introduced by #686

commit d8f80f8f8f6ab4fec285a3fd52163836aa6b5f10
Merge: 66dcb3f ae368d4
Author: Jesse Szwedko <jesse.szwedko@gmail.com>
Date:   Sun Dec 3 12:48:28 2017 -0800

    Merge pull request #686 from baude/shortoptionSkipArg

    Handle ShortOptions and SkipArgReorder

commit c315e9b4aa19de06b22cee53c90a9cc9503dc5f0
Author: Gábor Lipták <gliptak@gmail.com>
Date:   Thu Nov 30 19:43:12 2017 -0500

    Correct go vet for Go tip

    https://travis-ci.org/cloudflare/logshare/jobs/309796141#L646

commit ae368d4baa9f30454955b71c30b908d1211cfd55
Author: baude <bbaude@redhat.com>
Date:   Mon Nov 20 09:32:03 2017 -0600

    Handle ShortOptions and SkipArgReorder

    There was a bug in parsing when both ShortOptions
    and SkipArgReorder were being used together.

    Signed-off-by: baude <bbaude@redhat.com>

commit 66dcb3f4e5aa5178cf13f4f5db0a93819dc48cfe
Merge: 5e7fdf3 806f93c
Author: Jesse Szwedko <jesse.szwedko@gmail.com>
Date:   Mon Nov 27 19:55:04 2017 -0800

    Merge pull request #687 from joshuarubin/master

    Don't clobber slices with EnvVar

commit 806f93c65d90cd3d8e189c8d92f38df2e6e9934c
Author: Joshua Rubin <jrubin@zvelo.com>
Date:   Tue Nov 21 15:21:31 2017 -0700

    dont clobber slices with envvar

    Signed-off-by: Joshua Rubin <jrubin@zvelo.com>

commit 5e7fdf3529bd63ef83bd7740bdd4badd71bfcd58
Merge: 45b1e0f 3862ad2
Author: Jesse Szwedko <jesse.szwedko@gmail.com>
Date:   Wed Nov 15 20:56:12 2017 -0800

    Merge pull request #684 from baude/shortOptionHandling

    Combine bool short names

commit 3862ad28f2f23ded2d2f251dfbcf23d1d72c5629
Author: baude <bbaude@redhat.com>
Date:   Mon Nov 13 15:28:23 2017 -0600

    Combine bool short names

    Adds the ability to allow the combination of bool
    short-name options.  For example,

    cmd foobar -ov

    This is done through a bool "UseShortOptionHandler" set in
    the command struct.

    Built upon PR #621

    Signed-off-by: baude <bbaude@redhat.com>

commit d479aa82e80b0f1a8e3241ebf52dba64f5af02fc
Author: Jesse Szwedko <jesse.szwedko@gmail.com>
Date:   Sat Nov 11 16:23:24 2017 -0800

    Update README examples to check for errors

    To encourage good practices.

commit dfb0295ead52ae173bc7c31b765da2247cdb927b
Author: zhuchensong <zhuchensong93@163.com>
Date:   Mon Apr 17 00:47:04 2017 +0800

    Support POSIX-style short flag combining

commit 45b1e0f036b82e838a7706d5d36ade6521503f3a
Merge: 296fb62 b498750
Author: Jesse Szwedko <jesse.szwedko@gmail.com>
Date:   Fri Nov 3 19:35:40 2017 -0700

    Merge pull request #675 from jmccann/continue3

    Ability to load variable from file - UPDATED

commit b4987506a6e213892b213d7a423ed699f5e3f79d
Author: Jacob McCann <jacob.mccann2@target.com>
Date:   Thu Oct 26 13:08:03 2017 -0500

    Allow FilePath to take []string

commit 877db204917fefb9122483837c72efdf5134be5c
Author: Brad Rydzewski <brad.rydzewski@gmail.com>
Date:   Mon Apr 10 16:45:51 2017 +0200

    fix FilePath documentation in README.md

commit c909cd88ce1e552312ad6cfce31170363ff92fd9
Author: Brad Rydzewski <brad.rydzewski@gmail.com>
Date:   Sat Apr 1 12:55:46 2017 +0900

    document field in README

commit 5448b9175dfda2c780787e83ab6722c58591bb85
Author: Brad Rydzewski <brad.rydzewski@gmail.com>
Date:   Sat Apr 1 12:37:06 2017 +0900

    unit tests for load from file

commit 9ca29fa2ad3f97f9c62377c34db1e9b7ae06f3b4
Author: Brad Rydzewski <brad.rydzewski@gmail.com>
Date:   Fri Mar 31 16:24:15 2017 +0900

    ability to load variable from file

commit 296fb62e2ecaa43044a99f27f456bc812c2ef1fe
Merge: f5ea501 beef21a
Author: Jesse Szwedko <jesse.szwedko@gmail.com>
Date:   Mon Oct 30 19:55:34 2017 -0700

    Merge pull request #676 from rliebz/lexicographic-sort

    Consider case when sorting strings

commit beef21a1fefe991989c28d67ef6ca0a0f1fec0ec
Author: Robert Liebowitz <rliebz@gmail.com>
Date:   Sat Oct 28 03:00:11 2017 -0400

    Consider case when sorting strings

    This makes sorting flags and other sections consistent with how most
    command line tools function, by placing both flags `-A` and `-a` before
    a flag `-B`.

commit f5ea501f29b733ffe5b47280e9ba0952aa6d6e93
Merge: fc9e81c c7278d1
Author: Jesse Szwedko <jesse.szwedko@gmail.com>
Date:   Sat Oct 14 13:27:26 2017 -0700

    Merge pull request #628 from phinnaeus/master

    Allow custom ExitError handler function

commit c7278d100553de22e199d65430a1572437d250a9
Merge: b63d1c6 fc9e81c
Author: Tyler Davis <phinnaeus@users.noreply.github.com>
Date:   Fri Oct 13 12:05:14 2017 -0700

    Merge branch 'master' into master

commit fc9e81c46a927d6c244c7c70138481e990a1660b
Merge: fc37bde 8793ca7
Author: Jesse Szwedko <jesse.szwedko@gmail.com>
Date:   Sat Oct 7 13:56:23 2017 -0700

    Merge pull request #672 from sierraechobravo/master

    fix go report card issues

commit 8793ca77b7dd4e60632e9dbb465f5cc12c65b053
Author: Sebastian Sprenger <Sebastian.Sprenger@booxware.de>
Date:   Fri Oct 6 07:29:13 2017 +0200

    fix golint issues

commit 2f6b77f0580a941fbe02edec22df747b7f13e933
Author: Sebastian Sprenger <Sebastian.Sprenger@booxware.de>
Date:   Fri Oct 6 07:28:43 2017 +0200

    fix ineffective assigns

commit f7ae5e5613516e19e8cc40b3afa73ef3f17743ab
Author: Sebastian Sprenger <Sebastian.Sprenger@booxware.de>
Date:   Fri Oct 6 07:28:18 2017 +0200

    fix misspelling issue

commit fc37bde42ef0c4c7d200bdb29db27100f1f67bc2
Merge: 4d41dbd 9b1d2a3
Author: Jesse Szwedko <jesse.szwedko@gmail.com>
Date:   Mon Sep 25 20:41:18 2017 -0700

    Merge pull request #661 from rliebz/custom-flag-help

    Allow customization of prefixes and environment variable hints in flag help strings

commit b63d1c6691790db4c5f8acb940a9bcd33c35384e
Merge: 046fb1f 4d41dbd
Author: Tyler Davis <phinnaeus@users.noreply.github.com>
Date:   Fri Sep 22 10:08:36 2017 -0700

    Merge branch 'master' into master

commit 9b1d2a3ba3259d1b2133c6ce462c014a57069188
Author: Robert Liebowitz <rliebz@gmail.com>
Date:   Mon Sep 18 00:44:42 2017 -0400

    Add tests for custom flag prefix/env hints

commit 2628d50c445f1d7daad935d25df700261a4c4141
Author: rliebz <rliebz@gmail.com>
Date:   Sat Aug 26 07:42:25 2017 -0400

    Export funcs to configure flag prefix/env hints

    This will allow users to customize the prefix section or env hint
    section of the flag entries in the help menu without having to
    reimplement the rest of the logic required in defining FlagStringer.

commi…
  • Loading branch information
@asahasrabuddhe
asahasrabuddhe committed Sep 16, 2019
1 parent 9d498d2 commit e48c09f
Show file tree
Hide file tree
Showing 18 changed files with 32 additions and 197 deletions.
6 changes: 3 additions & 3 deletions cli/CHANGELOG.md
View file
Expand Up @@ -20,10 +20,10 @@
To migrate to the new API, you may choose to run [the migrator
(python) script](./cli-v1-to-v2).
- The optimistic reordering of arguments and flags introduced by
https://github.com/codegangsta/cli/pull/36. This behavior only worked when
https://github.com/urfave/cli/pull/36. This behavior only worked when
all arguments appeared before all flags, but caused [weird issues with boolean
flags](https://github.com/codegangsta/cli/issues/103) and [reordering of the
arguments](https://github.com/codegangsta/cli/issues/355) when the user
flags](https://github.com/urfave/cli/issues/103) and [reordering of the
arguments](https://github.com/urfave/cli/issues/355) when the user
attempted to mix flags and arguments. Given the trade-offs we removed support
for this reordering.
- adapter code for deprecated `Action` func signature
Expand Down
16 changes: 6 additions & 10 deletions cli/README.md
View file
Expand Up @@ -19,7 +19,7 @@ applications in an expressive way.
- [Installation](#installation)
* [Supported platforms](#supported-platforms)
* [Using the `v2` branch](#using-the-v2-branch)
* [Pinning to the `v1` releases](#pinning-to-the-v1-releases)
* [Using `v1` releases](#using-v1-releases)
- [Getting Started](#getting-started)
- [Examples](#examples)
* [Arguments](#arguments)
Expand Down Expand Up @@ -104,9 +104,6 @@ import (
...
```

**NOTE**: There is a [migrator (python) script](./cli-v1-to-v2) available to aid
with the transition from the v1 to v2 API.

### Pinning to the `v1` releases

Similarly to the section above describing use of the `v2` branch, if one wants
Expand All @@ -120,7 +117,7 @@ $ go get github.com/urfave/cli
```go
...
import (
"github.com/urfave/cli/v2"
"github.com/urfave/cli"
)
...
```
Expand Down Expand Up @@ -710,11 +707,10 @@ Here is a more complete sample of a command using YAML support:
"output": "&#45&#45;test value.*default: 0"
} -->
``` go
package notmain
package main

import (
"fmt"
"log"
"os"

"github.com/urfave/cli/v2"
Expand All @@ -735,7 +731,7 @@ func main() {
Before: altsrc.InitInputSourceWithContext(flags, altsrc.NewYamlSourceFromFlagFunc("load")),
Flags: flags,
}

app.Run(os.Args)
}
```
Expand Down Expand Up @@ -949,7 +945,7 @@ func main() {
},
Action: func(ctx *cli.Context) error {
if !ctx.Bool("ginger-crouton") {
return cli.Exit(Ginger croutons are not in the soup, 86)
return cli.Exit("Ginger croutons are not in the soup", 86)
}
return nil
},
Expand Down Expand Up @@ -986,7 +982,7 @@ import (
"fmt"
"log"
"os"

"github.com/urfave/cli/v2"
)

Expand Down
7 changes: 4 additions & 3 deletions cli/altsrc/json_source_context.go
View file
Expand Up @@ -66,10 +66,10 @@ func (x *jsonSource) Int(name string) (int, error) {
return 0, fmt.Errorf("unexpected type %T for %q", i, name)
case int:
return v, nil
case float64:
return int(v), nil
case float32:
return int(v), nil
case float64:
return int(v), nil
}
}

Expand Down Expand Up @@ -203,5 +203,6 @@ func jsonGetValue(key string, m map[string]interface{}) (interface{}, error) {

type jsonSource struct {
file string
deserialized map[string]interface{}
deserialized map[string]interface {
}
}
2 changes: 1 addition & 1 deletion cli/altsrc/toml_command_test.go
View file
Expand Up @@ -241,7 +241,7 @@ func TestCommandTomlFileTestDefaultValueFileWinsNested(t *testing.T) {
}

func TestCommandTomlFileFlagHasDefaultGlobalEnvTomlSetGlobalEnvWins(t *testing.T) {
app := (&cli.App{})
app := &cli.App{}
set := flag.NewFlagSet("test", 0)
_ = ioutil.WriteFile("current.toml", []byte("test = 15"), 0666)
defer os.Remove("current.toml")
Expand Down
43 changes: 8 additions & 35 deletions cli/app.go
View file
Expand Up @@ -11,16 +11,14 @@ import (
"time"
)

var (
changeLogURL = "https://github.com/urfave/cli/blob/master/CHANGELOG.md"
appActionDeprecationURL = fmt.Sprintf("%s#deprecated-cli-app-action-signature", changeLogURL)

contactSysadmin = "This is an error in the application. Please contact the distributor of this application if this is not you."

errInvalidActionType = NewExitError("ERROR invalid Action type. "+
fmt.Sprintf("Must be `func(*Context`)` or `func(*Context) error). %s", contactSysadmin)+
fmt.Sprintf("See %s", appActionDeprecationURL), 2)
)
//var (
// changeLogURL = "https://github.com/urfave/cli/blob/master/CHANGELOG.md"
// appActionDeprecationURL = fmt.Sprintf("%s#deprecated-cli-app-action-signature", changeLogURL)
// contactSysadmin = "This is an error in the application. Please contact the distributor of this application if this is not you."
// errInvalidActionType = NewExitError("ERROR invalid Action type. "+
// fmt.Sprintf("Must be `func(*Context`)` or `func(*Context) error). %s", contactSysadmin)+
// fmt.Sprintf("See %s", appActionDeprecationURL), 2)
//)

// App is the main structure of a cli application. It is recommended that
// an app be created with the cli.NewApp() function
Expand Down Expand Up @@ -534,28 +532,3 @@ func (a *Author) String() string {

return fmt.Sprintf("%v%v", a.Name, e)
}

// DefaultAppComplete returns an ActionFunc to run a default command if non were passed.
// Usage: `app.Action = cli.DefaultCommand("command")`
func DefaultCommand(name string) ActionFunc {
return func(ctx *Context) error {
return ctx.App.Command(name).Run(ctx)
}
}

// HandleAction attempts to figure out which Action signature was used. If
// it's an ActionFunc or a func with the legacy signature for Action, the func
// is run!
func HandleAction(action interface{}, context *Context) (err error) {
switch a := action.(type) {
case ActionFunc:
return a(context)
case func(*Context) error:
return a(context)
case func(*Context): // deprecated function signature
a(context)
return nil
}

return errInvalidActionType
}
74 changes: 0 additions & 74 deletions cli/app_test.go
View file
Expand Up @@ -445,63 +445,6 @@ func TestApp_Setup_defaultsWriter(t *testing.T) {
expect(t, app.Writer, os.Stdout)
}


//func TestApp_CommandWithArgBeforeFlags(t *testing.T) {
// var parsedOption, firstArg string
//
// app := NewApp()
// command := &Command{
// Name: "cmd",
// Flags: []Flag{
// &StringFlag{Name: "option", Value: "", Usage: "some option"},
// },
// Action: func(c *Context) error {
// parsedOption = c.String("option")
// firstArg = c.Args().First()
// return nil
// },
// }
// app.Commands = []*Command{command}
//
// _ = app.Run([]string{"", "cmd", "my-arg", "--option", "my-option"})
//
// expect(t, parsedOption, "my-option")
// expect(t, firstArg, "my-arg")
//}
//
//func TestApp_CommandWithArgBeforeBoolFlags(t *testing.T) {
// var parsedOption, parsedSecondOption, firstArg string
// var parsedBool, parsedSecondBool bool
//
// app := NewApp()
// command := &Command{
// Name: "cmd",
// Flags: []Flag{
// &StringFlag{Name: "option", Value: "", Usage: "some option"},
// &StringFlag{Name: "secondOption", Value: "", Usage: "another option"},
// &BoolFlag{Name: "boolflag", Usage: "some bool"},
// &BoolFlag{Name: "b", Usage: "another bool"},
// },
// Action: func(c *Context) error {
// parsedOption = c.String("option")
// parsedSecondOption = c.String("secondOption")
// parsedBool = c.Bool("boolflag")
// parsedSecondBool = c.Bool("b")
// firstArg = c.Args().First()
// return nil
// },
// }
// app.Commands = []*Command{command}
//
// _ = app.Run([]string{"", "cmd", "my-arg", "--boolflag", "--option", "my-option", "-b", "--secondOption", "fancy-option"})
//
// expect(t, parsedOption, "my-option")
// expect(t, parsedSecondOption, "fancy-option")
// expect(t, parsedBool, true)
// expect(t, parsedSecondBool, true)
// expect(t, firstArg, "my-arg")
//}

func TestApp_RunAsSubcommandParseFlags(t *testing.T) {
var context *Context

Expand Down Expand Up @@ -2073,23 +2016,6 @@ func TestHandleExitCoder_Custom(t *testing.T) {
}
}

func TestHandleAction_WithUnknownPanic(t *testing.T) {
defer func() { refute(t, recover(), nil) }()

var fn ActionFunc

app := NewApp()
app.Action = func(ctx *Context) error {
_ = fn(ctx)
return nil
}
fs, err := flagSet(app.Name, app.Flags)
if err != nil {
t.Errorf("error creating FlagSet: %s", err)
}
_ = HandleAction(app.Action, NewContext(app, fs, nil))
}

func TestShellCompletionForIncompleteFlags(t *testing.T) {
app := &App{
Flags: []Flag{
Expand Down
1 change: 0 additions & 1 deletion cli/appveyor.yml
View file
Expand Up @@ -26,4 +26,3 @@ build_script:
- go run build.go vet
- go run build.go test
- go run build.go gfmrun

4 changes: 0 additions & 4 deletions cli/command.go
View file
Expand Up @@ -184,10 +184,6 @@ func (c *Command) parseFlags(args Args) (*flag.FlagSet, error) {
return set, set.Parse(append([]string{"--"}, args.Tail()...))
}

//if !c.SkipArgReorder {
// args = reorderArgs(args)
//}

set, err := parseIter(c, args.Tail())
if err != nil {
return nil, err
Expand Down
2 changes: 1 addition & 1 deletion cli/command_test.go
View file
Expand Up @@ -28,7 +28,7 @@ func TestCommandFlagParsing(t *testing.T) {
for _, c := range cases {
app := &App{Writer: ioutil.Discard}
set := flag.NewFlagSet("test", 0)
set.Parse(c.testArgs)
_ = set.Parse(c.testArgs)

context := NewContext(app, set, nil)

Expand Down
54 changes: 1 addition & 53 deletions cli/context.go
View file
Expand Up @@ -74,40 +74,11 @@ func (c *Context) IsSet(name string) bool {
}
}

// XXX hack to support IsSet for flags with EnvVar
//
// There isn't an easy way to do this with the current implementation since
// whether a flag was set via an environment variable is very difficult to
// determine here. Instead, we intend to introduce a backwards incompatible
// change in version 2 to add `IsSet` to the Flag interface to push the
// responsibility closer to where the information required to determine
// whether a flag is set by non-standard means such as environment
// variables is available.
//
// See https://github.com/urfave/cli/issues/294 for additional discussion
f := lookupFlag(name, c)
if f == nil {
return false
}

//val := reflect.ValueOf(f)
//if val.Kind() == reflect.Ptr {
// val = val.Elem()
//}
//
//filePathValue := val.FieldByName("FilePath")
//if !filePathValue.IsValid() {
// return false
//}
//
//envVarValues := val.FieldByName("EnvVars")
//if !envVarValues.IsValid() {
// return false
//}
//
//_, ok := flagFromEnvOrFile(envVarValues.Interface().([]string), filePathValue.Interface().(string))
//return ok

return f.IsSet()
}

Expand All @@ -132,30 +103,6 @@ func (c *Context) FlagNames() []string {
return names
}

// FlagNames returns a slice of flag names used in this context.
//func (c *Context) FlagNames() (names []string) {
// for _, f := range c.Command.Flags {
// name := strings.Split(f.GetName(), ",")[0]
// if name == "help" {
// continue
// }
// names = append(names, name)
// }
// return
//}

// GlobalFlagNames returns a slice of global flag names used by the app.
//func (c *Context) GlobalFlagNames() (names []string) {
// for _, f := range c.App.Flags {
// name := strings.Split(f.GetName(), ",")[0]
// if name == "help" || name == "version" {
// continue
// }
// names = append(names, name)
// }
// return names
//}

// Lineage returns *this* context and all of its ancestor contexts in order from
// child to parent
func (c *Context) Lineage() []*Context {
Expand Down Expand Up @@ -310,6 +257,7 @@ func checkRequiredFlags(flags []Flag, context *Context) requiredFlagsErr {
if rf, ok := f.(RequiredFlag); ok && rf.IsRequired() {
var flagPresent bool
var flagName string

for _, key := range f.Names() {
if len(key) > 1 {
flagName = key
Expand Down
4 changes: 1 addition & 3 deletions cli/context_test.go
View file
Expand Up @@ -3,12 +3,9 @@ package cli
import (
"context"
"flag"

"sort"

"os"
"strings"

"testing"
"time"
)
Expand Down Expand Up @@ -462,6 +459,7 @@ func TestCheckRequiredFlags(t *testing.T) {
parseInput: []string{"-n", "asd", "-n", "qwe"},
},
}

for _, test := range tdata {
t.Run(test.testCase, func(t *testing.T) {
// setup
Expand Down
3 changes: 1 addition & 2 deletions cli/flag.go
View file
Expand Up @@ -314,7 +314,7 @@ func stringifyIntSliceFlag(f *IntSliceFlag) string {
var defaultVals []string
if f.Value != nil && len(f.Value.Value()) > 0 {
for _, i := range f.Value.Value() {
defaultVals = append(defaultVals, fmt.Sprintf("%d", i))
defaultVals = append(defaultVals, strconv.Itoa(i))
}
}

Expand Down Expand Up @@ -346,7 +346,6 @@ func stringifyFloat64SliceFlag(f *Float64SliceFlag) string {

func stringifyStringSliceFlag(f *StringSliceFlag) string {
var defaultVals []string

if f.Value != nil && len(f.Value.Value()) > 0 {
for _, s := range f.Value.Value() {
if len(s) > 0 {
Expand Down

0 comments on commit e48c09f

Please sign in to comment.