Refactor Session serveMessage and mutex usage #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
just preparing for the actual changes
1 task
aruiz14
requested review from
rmweir,
tomleb and
a team
and removed request for
a team
aruiz14
changed the title
aruiz14
force-pushed
the
refactor-session-serve
branch
from
33d757e
to
1301d89
Compare
rmweir
suggested changes
May 2, 2024
…hat require coordination
Co-authored-by: Ricardo Weir <ricardo.weir@suse.com>
aruiz14
force-pushed
the
refactor-session-serve
branch
from
c461575
to
ba93557
Compare
aruiz14
force-pushed
the
refactor-session-serve
branch
from
ba93557
to
03cf07c
Compare
nflynt
approved these changes
May 24, 2024
moio
approved these changes
May 27, 2024
rmweir
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: 44576
Extracted a few modifications required in during the review of #74.
session.serveMessagefor the sake of simplicity. It now just parses the raw message and calls the appropriate method, and also moved relevant methods to an independent file.sync.MutexinSessionwith aRWMutex. Also, creating new methods to interact with the protected map, hence avoiding (most) of the callers to lock and unlock.wsConninto an interface, converting the existingwsConnintowsWrapper. This eases testing.