Add new UI Settings for page banners #45528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@prachidamle Could you assign a backend reviewer, please. FYI @gaktive |
|
@nwmac you rock. |
nwmac
force-pushed
the
add-ui-banner-settings
branch
from
c444d73
to
0d3b2c1
Compare
nwmac
force-pushed
the
add-ui-banner-settings
branch
from
0d3b2c1
to
dc04d4c
Compare
maxsokolovsky
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
rancher/dashboard#7366
Problem
Presently, all banners are in a single setting as a single JSON blob - this makes it hard for users wishing to individually configure banners outside of the UI.
Solution
Add optional individual banner settings that will be used if defined, rather than the single setting we currently have.
Testing
UI will add automated e2e tests to cover this feature and the correct operation of these new settings.