Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new setting for UI Extension configuration #45527

Merged
merged 7 commits into from
Jun 4, 2024

Conversation

nwmac
Copy link
Member

@nwmac nwmac commented May 17, 2024

Issue:

rancher/dashboard#11047

Problem

Need a way to more easily enable/disable extensions without install/uninstall - especially useful for built-in extensions that we might want to allow the user to disable.

Solution

Add a new setting ui-extensions that can be used to store the required configuration.

Testing

Testing will be covered by end-to-end and unit tests in the relating UI work.

@nwmac nwmac requested a review from torchiaf May 17, 2024 11:17
@nwmac nwmac self-assigned this May 17, 2024
@nwmac nwmac added this to the v2.9-Next1 milestone May 17, 2024
@nwmac
Copy link
Member Author

nwmac commented May 17, 2024

@prachidamle Can you assign a reviewer from backend for this, please. Thank you. FYI @gaktive

Copy link
Contributor

@torchiaf torchiaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Should the new setting also be available before authentication ?

@nwmac nwmac force-pushed the add-ui-extensions-setting branch 2 times, most recently from a46167c to b3bb67d Compare May 31, 2024 12:39
@nwmac nwmac force-pushed the add-ui-extensions-setting branch from b3bb67d to d6afdfe Compare June 1, 2024 16:07
@nwmac nwmac merged commit f7a9ebc into rancher:release/v2.9 Jun 4, 2024
2 checks passed
@nwmac nwmac deleted the add-ui-extensions-setting branch June 4, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants