-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v2.9] pin rancher capi chart version #45438
[v2.9] pin rancher capi chart version #45438
Conversation
4b81e18
to
726e4cb
Compare
726e4cb
to
59edec0
Compare
59edec0
to
1c33df4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test approval, will dismiss soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one nit, feel free to fix that later in 1.30 open PR if needed
@@ -191,6 +191,9 @@ var ( | |||
// RancherWebhookVersion is the exact version of the webhook that Rancher will install. | |||
RancherWebhookVersion = NewSetting("rancher-webhook-version", "") | |||
|
|||
// RancherWebhookVersion is the exact version of the webhook that Rancher will install. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: the comment needs to updated for RancherProvisioningCAPIVersion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will fix with 1.30 PR. thanks for pointing it out.
Merging this one for now.
Issue:
#45099
Problem
capi chart was being auto upgraded to newer version and if there are some breaking changes in the new CAPI chart it was breaking an older running rancher instance.
Solution
pin CAPI chart to a fix version in rancher through settings.
Testing
Note: the testing was done with 103.2.0+up0.0.1 but after that 104.0.0+up0.2.0 was available so updated this version in the PR
rancher docker install and checking the CAPI chart version.
--> successful chart version is same as the one specified in build.yaml
103.2.0+up0.0.1
rancher docker install with env variable to override the chart version to
103.0.0+up0.0.1
--> successful chart version is same as the env variable passed.
Engineering Testing
Manual Testing
Automated Testing
Summary: TODO
QA Testing Considerations
Regressions Considerations
TODO
Existing / newly added automated tests that provide evidence there are no regressions: