-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SAML SLO support #45379
Open
andreas-kupries
wants to merge
15
commits into
rancher:release/v2.9
Choose a base branch
from
andreas-kupries:ak-38494-sure-3572-saml-single-logout
base: release/v2.9
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
SAML SLO support #45379
andreas-kupries
wants to merge
15
commits into
rancher:release/v2.9
from
andreas-kupries:ak-38494-sure-3572-saml-single-logout
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreas-kupries
force-pushed
the
ak-38494-sure-3572-saml-single-logout
branch
from
May 6, 2024 12:55
6788bc7
to
2d218c6
Compare
…supported, enabled, forced. added structures for logout request and response. regenerated code and yaml side work: documented nature of InitializeSamlServiceProvider
… interceptor callback
andreas-kupries
force-pushed
the
ak-38494-sure-3572-saml-single-logout
branch
from
June 4, 2024 13:07
4f7f7a6
to
cbb7eda
Compare
…nable serialization to and from json
… to work while cause of the validation issue is researched and debugged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Fix #38494
This work is co-dependent on the UI work tracked at rancher/dashboard#10941
Problem
SURE 3572
Solution
PR holds work checkpoints at the moment. Not in a merge-able state.
AuthConfig
,SamlConfig
with the proposed flags about SLO (supported
,enabled
,forced
).supported
flag might be nonsense.SamlConfigLogoutInput
, and...Output
. Same fields as the knownSamlConfigTest...
structures. Hold the request/response data from/to the UI for thelogoutAll
action (see below).tokens
API should export a new actionlogoutAll
.KNOWN ISSUES: Does not guard against call of regular logout when SLO is forced.
Does guard against forced but not enabled, and call to logout-all when not enabled.
Testing
Engineering Testing
Manual Testing
Automated Testing
Summary: TODO
QA Testing Considerations
Regressions Considerations
TODO
Existing / newly added automated tests that provide evidence there are no regressions: