Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge "Global Permission Assignment" subsections #881

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lindhe
Copy link
Contributor

@lindhe lindhe commented Sep 26, 2023

Reminders

  • See the README for more details on how to work with the Rancher docs.

  • Verify if changes pertain to other versions of Rancher. If they do, finalize the edits on one version of the page, then apply the edits to the other versions.

  • If the pull request is dependent on an upcoming release, make sure to target the release branch instead of main.

Description

This change consolidates the "Global Permission Assignment" instructions for local users and users who log in to Rancher using external authentication.

It said that "Global permissions for local users are assigned differently than users who log in to Rancher using external authentication", yet the instructions were identical (apart from some incorrect information, as far as I can tell).

Comments

If you like these changes, I'll make the same change for the versioned docs too.

Relates to #878

This change consolidates the "Global Permission Assignment" instructions
for local users and users who log in to Rancher using external
authentication.

It said that "Global permissions for local users are assigned differently than users who log in to Rancher using external authentication", yet the instructions were identical (apart from some incorrect information, as far as I can tell).

Signed-off-by: Andreas Lindhé <andreas@lindhe.io>
@lindhe
Copy link
Contributor Author

lindhe commented Sep 27, 2023

I see that it's repeated yet again later on the same page: https://github.com/rancher/rancher-docs/blob/091ecbdde64219fcfa817b5a5f1cff821b042770/docs/how-to-guides/new-user-guides/authentication-permissions-and-global-configuration/manage-role-based-access-control-rbac/global-permissions.md#configuring-default-global-permissions

Should we remove this too? It seems like unnecessary work to put so many repeating statements in the same document...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant