tuning: recommend minimum browser specs #1290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moio
requested review from
btat,
LucasSaintarbor,
martyav and
sunilarjun
as code owners
moio
force-pushed
the
tuning_require_browser_specs
branch
from
69f0e8d
to
cd3de86
Compare
martyav
requested changes
May 15, 2024
...rence-guides/best-practices/rancher-server/tuning-and-best-practices-for-rancher-at-scale.md
Outdated
Show resolved
Hide resolved
...rence-guides/best-practices/rancher-server/tuning-and-best-practices-for-rancher-at-scale.md
Outdated
Show resolved
Hide resolved
...rence-guides/best-practices/rancher-server/tuning-and-best-practices-for-rancher-at-scale.md
Outdated
Show resolved
Hide resolved
...rence-guides/best-practices/rancher-server/tuning-and-best-practices-for-rancher-at-scale.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Silvio Moioli <silvio@moioli.net> Co-authored-by: Marty Hernandez Avedon <marty.avedon@suse.com>
moio
force-pushed
the
tuning_require_browser_specs
branch
from
d08b27a
to
9f1a8e3
Compare
|
Note I disagree with vale about the ordinal in this case - Intel marketing material and the industry in general uses it ubiquitously to indicate microprocessor architectures. I think spelling out the ordinal would make it less familiar for readers. |
|
@moio It's a good point, I hesitated on that one. The docs team went over how applicable the OpenSUSE Vale style guide is to our situation last week, and made note of some rules that need adjusting. This probably needs to be updated to something like "Ordinals are preferred when listing tech specs" |
martyav
approved these changes
May 16, 2024
martyav
approved these changes
May 20, 2024
|
LGTM, thanks Silvio! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Clarify that in high scale scenarios additional requirements apply to the machine running the browser that navigates the Rancher UI.
Comments
This applies to all versions current and future - for the time being I changed all files identically and opened this PR against the main branch.