#1283 update Rancher security best practices to address public IP exposure #1287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martyav
requested review from
btat,
LucasSaintarbor and
sunilarjun
as code owners
sunilarjun
reviewed
May 16, 2024
docs/reference-guides/rancher-security/rancher-security-best-practices.md
Outdated
Show resolved
Hide resolved
martyav
commented
May 16, 2024
docs/reference-guides/rancher-security/rancher-security-best-practices.md
Outdated
Show resolved
Hide resolved
sunilarjun
approved these changes
May 16, 2024
btat
reviewed
May 22, 2024
| You should protect the following ports behind an [external load balancer](../../how-to-guides/new-user-guides/kubernetes-resources-setup/load-balancer-and-ingress-controller/layer-4-and-layer-7-load-balancing.md#layer-4-load-balancer) that has SSL offload enabled: | ||
|
|
||
| - **K3s:** Port 6443, used by the Kubernetes API. | ||
| - **RKE2:** Port 6443, used by the Kubernetes API, and port 9345, used for node registration. |
There was a problem hiding this comment.
Does RKE(1) require any action?
There was a problem hiding this comment.
I left a comment asking about this on the associated security issue
|
I haven't heard back in 3 weeks, I'm just going to merge as the information is important and relevant. If we do hear back on RKE1 we can update the page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1283
Reminders
See the README for more details on how to work with the Rancher docs.
Verify if changes pertain to other versions of Rancher. If they do, finalize the edits on one version of the page, then apply the edits to the other versions.
If the pull request is dependent on an upcoming release, make sure to target the release branch instead of
main.Description
This adds some information about how to protect from nodes' public IP addresses being exposed. It's an internal request from the security repo. The PR also reduces the levels on the headings from 3 to 2, since there is no intervening second level heading between them and the H1 title.
Comments