Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update use-fleet-behind-a-proxy.md #1285

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

emilianolangella
Copy link

I can't find "Agent Environment Vars" under the "Advanced Options", but only under "Cluster Configuration":

Screenshot from 2024-05-14 13-40-55

I don't see the "Agent Environment Vars" under the "Advanced Options".
@martyav martyav added the sync-versions Reminder to sync versioned pages label May 14, 2024
@martyav
Copy link
Contributor

martyav commented May 14, 2024

@emilianolangella what version are you running?

I checked an instance running v2.7 and Agent Environment Variables is located as described in the current docs.

If you're on v2.8, then when we update the versioned pages we only need to update v2.8 and not any further back.

@emilianolangella
Copy link
Author

I have 2.8.3.

martyav
martyav previously approved these changes May 20, 2024
Copy link
Contributor

@btat btat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The layout difference depends on if RKE or RKE2/K3s is used. We generally use Tabs to differentiate that.

Comment on lines 35 to 40
1. Click **☰ > Cluster Management**.
1. Go to the cluster where you want to add environment variables and click **⋮ > Edit Config**.
1. Click **Advanced Options**.
1. Click **Add Environment Variable**.
1. Click **Agent Environment Vars** under **Cluster configuration**.
1. Click **Add**.
1. Enter the [required environment variables](#required-environment-variables)
1. Click **Save**.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't make a direct suggestion due to the deleted line, but it should look something like this:

<Tabs groupId="k8s-distro">
<TabItem value="RKE2/K3s" default>
1. Click **☰ > Cluster Management**.
1. Go to the cluster where you want to add environment variables and click **⋮ > Edit Config**.
1. Click **Agent Environment Vars** under **Cluster configuration**.
1. Click **Add**.
1. Enter the [required environment variables](#required-environment-variables)
1. Click **Save**.
</TabItem>
<TabItem value="RKE" default>
1. Click **☰ > Cluster Management**.
1. Go to the cluster where you want to add environment variables and click **⋮ > Edit Config**.
1. Click **Advanced Options**.
1. Click **Add Environment Variable**.
1. Enter the [required environment variables](#required-environment-variables)
1. Click **Save**.
</TabItem>
</Tabs>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sync-versions Reminder to sync versioned pages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants