Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix azure devops git clone error #400

Merged
merged 3 commits into from Jan 8, 2024

Conversation

raulcabello
Copy link
Contributor

@raulcabello raulcabello commented Jan 4, 2024

Azure DevOps requires capabilities multi_ack / multi_ack_detailed, which are not fully implemented and by default are included in transport.UnsupportedCapabilities.

This PR modifies the transport.UnsupportedCapabilities, so that git repos from Azure DevOps can be cloned. See this example, this PR and this issue for more info.

refers to rancher/fleet#2043

Copy link
Contributor

@weyfonk weyfonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have a test case for this to detect possible regressions?

@raulcabello
Copy link
Contributor Author

raulcabello commented Jan 5, 2024

Should we have a test case for this to detect possible regressions?

assertion added in 6e65838

@raulcabello raulcabello merged commit 4d30c6a into release/fleet/v0.9 Jan 8, 2024
5 checks passed
@raulcabello raulcabello deleted the fix-azuredevops-git-clone branch January 8, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants