Add status reconcile tests #2416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manno
force-pushed
the
add-status-reconcile-tests
branch
from
383f119
to
6b878d7
Compare
rubhanazeem
force-pushed
the
add-status-reconcile-tests
branch
9 times, most recently
from
7ccb214
to
157aa9f
Compare
rubhanazeem
force-pushed
the
add-status-reconcile-tests
branch
2 times, most recently
from
b08c007
to
c857009
Compare
rubhanazeem
force-pushed
the
add-status-reconcile-tests
branch
2 times, most recently
from
5f12e60
to
27674fa
Compare
0xavi0
reviewed
Jun 3, 2024
There was a problem hiding this comment.
I've added a few comments and questions.
In general I think we can check for more Status fields and verify that all fields make sense after updating dependant objects.
The tests make sense to verify that updating a bundledeployment triggers an update in bundle or gitrepo (for example), but I think we could also use the tests for verifying that the whole Status is what we expect to be.
rubhanazeem
force-pushed
the
add-status-reconcile-tests
branch
7 times, most recently
from
40cd41c
to
b184137
Compare
* BundleDeployment triggers Bundle * Bundle triggers GitRepo * BundleDeployment triggers Cluster * uses BundleDeployment and GitRepo for update * Cluster triggers ClusterGroup
Triggers by status change on bundleDeployments Triggers by a change in cluster
rubhanazeem
force-pushed
the
add-status-reconcile-tests
branch
from
b184137
to
8222ef2
Compare
0xavi0
previously approved these changes
Jun 10, 2024
manno
commented
Jun 10, 2024
0xavi0
previously approved these changes
Jun 10, 2024
0xavi0
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refers to #2400
Add integration tests to check status reconciles