Return commit for revision instead of HEAD #2410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xavi0
force-pushed
the
2403-return-commit-for-revision
branch
from
c8faecf
to
15f1912
Compare
Changing the commit retrieved when applying `gitrepo`s with revisions. It will show the commit for that revision/tag instead to the latest commit for the default branch (`master`) Refers to: rancher#2403 Signed-off-by: Xavi Garcia <xavi.garcia@suse.com>
0xavi0
force-pushed
the
2403-return-commit-for-revision
branch
from
15f1912
to
0fe19f9
Compare
0xavi0
force-pushed
the
2403-return-commit-for-revision
branch
2 times, most recently
from
3324f8d
to
f24ea88
Compare
0xavi0
force-pushed
the
2403-return-commit-for-revision
branch
2 times, most recently
from
174a77d
to
2780914
Compare
1 task
This is a refactoring of the code in `pkg/git` package in order to make it more testeable. It basically splits things into smaller entities and follows the interface/struct approach to make visible (and mockable) some previously internal code. Signed-off-by: Xavi Garcia <xavi.garcia@suse.com>
0xavi0
force-pushed
the
2403-return-commit-for-revision
branch
from
2780914
to
31a8bc1
Compare
manno
reviewed
May 22, 2024
Co-authored-by: Mario Manno <mario.manno@gmail.com>
manno
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the commit retrieved when applying
gitrepos with revisions. It will show the commit for that revision/tag instead to the latest commit for the default branch (master)It also refactors the code of the
pkg/gitpackage in order to make it more testable. (Now more than 95% of the code is covered by unit tests)It splits the previous code into different entities and functionalities.
ls-remotebut that are tied to vendors and their APIs, it is not generic and right now it only supportsgithubandgit.rancher.ioIt also changes how the latest commit is obtained to use the function using the vendor's API if available and falling back to
ls-remote.Reason why is because the function was already called with the following Headers:
ls-remotequery which is more expensive as we already know the latest commit for that branch.It also changes the error messages when a commit could not be retrieved, showing the branch or revision used.
This way the use is able to see, for example, that Fleet's defaults to
masteras default branch if the user didn't provide any branch in thegitrepodefinition and his/her repo hasmainas the default branch.Refers to: #2403
Refers to: #2404