Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging and document issue running act in a linked git worktree #2372

Merged
merged 2 commits into from
May 21, 2024

Conversation

p-se
Copy link
Contributor

@p-se p-se commented Apr 25, 2024

No description provided.

@p-se p-se self-assigned this Apr 25, 2024
@p-se p-se requested a review from a team as a code owner April 25, 2024 13:23
dev/README.md Outdated
#### fatal: not a git repository

```shell
get repo root in /tmp/foo: exit status 128: fatal: not a git repository
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the result of the improvement of the testing code in this PR. Without it, it just says not a git repository.

weyfonk
weyfonk previously approved these changes Apr 26, 2024
e2e/testenv/infra/cmd/setup.go Outdated Show resolved Hide resolved
@p-se p-se force-pushed the fleet-act-issue-with-git-worktree branch from 3462b46 to 6a61b60 Compare May 17, 2024 14:08
@p-se p-se requested a review from weyfonk May 17, 2024 14:21
Copy link
Contributor

@weyfonk weyfonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice documentation, thanks for this :)

@p-se p-se merged commit 5fbb852 into rancher:main May 21, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants