Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit recursion depth for cluster label replacement in values #1143

Merged
merged 1 commit into from
Dec 2, 2022
Merged

Limit recursion depth for cluster label replacement in values #1143

merged 1 commit into from
Dec 2, 2022

Conversation

manno
Copy link
Member

@manno manno commented Nov 30, 2022 •
edited

Let's merge this after #671 is in.

  • adds recursion depth check to cluster label replacement
  • rename "next" to "custom", because it is the value from the current "targetCustomization"
  • extract cluster label replacement string "global.fleet.clusterLabels." into a constant to make it more visible

@manno manno requested a review from a team as a code owner November 30, 2022 17:29
@manno manno merged commit 3f4e840 into master Dec 2, 2022
@manno manno deleted the limit-recursion-depth branch December 2, 2022 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thardeck thardeck thardeck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@manno @thardeck