Skip vtunnel readiness test #6880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mook-as
requested changes
May 14, 2024
| @@ -140,7 +140,7 @@ export const defaultSettings = { | |||
| }, | |||
| }, | |||
| /** windows only: if set, use gvisor based network rather than host-resolver/dnsmasq. */ | |||
| networkingTunnel: false, | |||
| networkingTunnel: true, | |||
There was a problem hiding this comment.
Did you mean to make this change in this PR?
There was a problem hiding this comment.
I did that intentionally so that I could trigger the e2e test again. I know I have a PR that makes this change, but as you know that depends on the e2e tests to pass.
The vtunnel process is not running when the network tunnel is enabled, therefore, we would not need to check for the process. Signed-off-by: Nino Kodabande <nkodabande@suse.com>
Nino-K
force-pushed
the
skip-vtunnel-check-network-tunnel
branch
from
ee60361
to
971b4a2
Compare
mook-as
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vtunnel process is not running when the network tunnel is enabled, therefore, we would not need to check for the process.
Related: #6422