Test PR do not merge #6868
Closed
Test PR do not merge #6868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mook-as
force-pushed
the
wip/test-go-work-sync
branch
4 times, most recently
from
8e151c4
to
0d5a89a
Compare
Signed-off-by: Mark Yen <mark.yen@suse.com>
The Actions token provided is unable to commit to forked repositories, even when the PR is set to allow pushes from maintainers. Disable this workflow when dealing with cross-repository pull requests. We will add a lint to check for this instead. Dependabot PRs should still work, as this will be triggered, which will then allow the PR to pass the lint. Signed-off-by: Mark Yen <mark.yen@suse.com>
mook-as
force-pushed
the
wip/test-go-work-sync
branch
6 times, most recently
from
3f10e34
to
abe7fa5
Compare
We also add the go modules handling to a lint step, so that 1) We can catch issues with cross-repository PRs. 2) We can fix it trivially by running `yarn lint` and committing. Signed-off-by: Mark Yen <mark.yen@suse.com>
This ensures that we get consistent output Signed-off-by: Mark Yen <mark.yen@suse.com>
Because the GitHub-provided token doesn't trigger further actions runs, it would not be great for dependabot pushes. Instead, try to use the token we may have if it's stored in the secrets. Signed-off-by: Mark Yen <mark.yen@suse.com>
This is needed due to the previous commit locating a bunch of module mismatches. Signed-off-by: Mark Yen <mark.yen@suse.com>
mook-as
force-pushed
the
wip/test-go-work-sync
branch
from
a25bf24
to
54cb4fd
Compare
Signed-off-by: Rancher Desktop Dependency Manager <donotuse@rancherdesktop.io>
|
Can this PR be closed? |
|
Yes, sorry about that; this was for #6858 and I forgot about it. Thanks for the reminder! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a test PR to check out permissions; this should never be merged.