Destroy BrowserView contents when closing
#4395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Phillip Rak <rak.phillip@gmail.com> Fix typo Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
rak-phillip
force-pushed
the
bugfix/4393-extension-leak
branch
from
f775ba1
to
0e6bbad
Compare
ericpromislow
approved these changes
Apr 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents the web contents of a
BrowserViewfrom leaking events by invokingwebContents.destroy().🗒️ Notes
webContents.destroy()is an undocumented methodwebContents.close()in later versions. We will need to come back at a later to usewebContents.close()after updating to the latest version of electron. RDX: ReplaceBrowserView.webContents.destroy()withBrowserView.webContents.close()#4394closes #4393