Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poor metrics performance from cri-dockerd (rancher desktop 1.2.x with dockerd) #2012

Closed
chancez opened this issue Apr 8, 2022 · 2 comments
Closed
Labels
kind/bug Something isn't working runtime/moby
Projects
Milestone

Comments

@chancez
Copy link
Contributor

chancez commented Apr 8, 2022

Actual Behavior

cri-dockerd metrics performance is much worse than with dockershim. See Mirantis/cri-dockerd#15 rancher/rke#2716 and rancher/rke#2709

Steps to Reproduce

  • LIMA_HOME="$HOME/Library/Application Support/rancher-desktop/lima" "/Applications/Rancher Desktop.app/Contents/Resources/resources/darwin/lima/bin/limactl" shell 0
  • sudo apk add curl jq
  • TOKEN="$(cat $(docker inspect "$(docker ps | grep metrics-server | grep -v POD | awk '{print $1}')" | jq '.[0].Mounts[] | select(.Destination=="/var/run/secrets/kubernetes.io/serviceaccount").Source' -r)/token)"
  • time curl https://192.168.192.50:10250/stats/summary?only_cpu_and_memory=true -k -v -H "Authorization: Bearer ${TOKEN}"

Result

Takes 10+ seconds to get a response, whereas with 1.1.1 it takes less than 10ms

...
* Connection #0 to host 192.168.192.50 left intact
}real	0m 11.70s
user	0m 0.01s
sys	0m 0.00s

Expected Behavior

Querying metrics is fast.

Additional Information

No response

Rancher Desktop Version

1.2.x

Rancher Desktop K8s Version

v1.22.7

Which container runtime are you using?

moby (docker cli)

What operating system are you using?

macOS

Operating System / Build Version

Darwin dune.local 21.4.0 Darwin Kernel Version 21.4.0: Fri Mar 18 00:46:32 PDT 2022; root:xnu-8020.101.4~15/RELEASE_ARM64_T6000 arm64

What CPU architecture are you using?

arm64 (Apple Silicon)

Linux only: what package format did you use to install Rancher Desktop?

No response

Windows User Only

No response

@chancez chancez added the kind/bug Something isn't working label Apr 8, 2022
@github-actions github-actions bot added this to To do in Stripey via automation Apr 8, 2022
@chancez
Copy link
Contributor Author

chancez commented Apr 8, 2022

Mirantis/cri-dockerd#38 seems to fix the issue. Replacing the binary and running /etc/init.d/cri-dockerd restart and curling the endpoint returns immediately.

@gunamata
Copy link
Contributor

will be fixed by #2022

@jandubois jandubois moved this from To do to Done in Stripey Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working runtime/moby
Projects
No open projects
Development

No branches or pull requests

3 participants