Add filtering by annotations on search #114
Conversation
Itxaka
force-pushed
the
filterannotation
branch
3 times, most recently
from
6b81217
to
3f63272
Compare
Itxaka
added
enhancement
| name: "search for hypper, expect latest version 0.2.0", | ||
| cmd: "search repo hypper --output yaml", | ||
| golden: "output/search-hypper-latest.txt", | ||
| }, { // I use yaml for the output because its easier to create the golden files, sue me :p |
Itxaka
force-pushed
the
filterannotation
branch
from
3f63272
to
4425c55
Compare
|
Rebased! |
Allows to add filtering by annotations by passing the -a flag and the annotation in the format "KEY=VALUE" So you can search like this: hypper search repo -a "catalog.cattle.io/certified=rancher" And it will only show charts that have that exact annotation. Signed-off-by: Itxaka <igarcia@suse.com>
Itxaka
force-pushed
the
filterannotation
branch
from
08e5cab
to
a3dd17a
Compare
There was a problem hiding this comment.
I was looking over #93 (the issue with the requirements for this). The idea is that Rancher has 1 charts repo and multiple versions of Rancher use it. Some chart versions will not work with some versions of Rancher. So, a version range of supported rancher versions on the chart could be used to filter for known supported versions.
To make this work we need to have more than a check on the existence of an annotation key/value pair.
For that same issue we need to expose this via a Go API. That can be a separate PR, though.
|
I dont understand @mattfarina This covers your user case correctly. You can use this to search for So this perfectly covers that. Now, please, if you have a specific case in mind, post it in the issue because if the issue is not clear or not defined enough, we are wasting time writing code that has to be refactored. This covers much more ground that the specific issue and its flexible enough to be used perfectly on hypper, plus brings value into hypper by making it all about annotations. |
|
What I understood from Matt is that, in addition to filtering on annotations, we want to have a semver ranges aware filter. So we could ask for things matching |
but then we are not being consequent here. Either we want to use a exact key to search in the annotations and make that semver aware, or we want this to not be rancher agnostic. Like if we are gonna search for If there is a key we want to search for that we know contains semver then we should say that in the ticket, otherwise we get a generic, not-tied-to-rancher, annotation filter search. Sure, we can be reckless and just try to load the values from the annotations into a semver constraint and fail otherwise but that is such a brute force approach that it makes no sense to me. Again, the ticket doesnt seem to be clear. Annotations can be of any type. If we want to search for just one annotation that contains the rancher version and do a semver constraint on there, good for me, I just need to know which annotation so we can discard the rest. Otherwise, lets build a more intelligent, generic annotation search that can be used to search also for hypper annotations! We seem to have an identity issue in which we either want hypper to be this community tool with a clear goal and suddenly we move as making hypper a vessel for rancher use cases. And this makes the hypper vision not clear enough IMO. In any case, I still think this bring value to hypper as it allows use to center ourselves on annotations and search for those. |
Allows to add filtering by annotations by passing the -a flag and the
annotation in the format "KEY=VALUE"
So you can search like this:
hypper search repo -a "catalog.cattle.io/certified=rancher"And it will only show charts that have that exact annotation.
Requires #113
Signed-off-by: Itxaka igarcia@suse.com