Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter based on annotations #93

Open
mattfarina opened this issue Mar 16, 2021 · 6 comments · Fixed by #114
Open

Filter based on annotations #93

mattfarina opened this issue Mar 16, 2021 · 6 comments · Fixed by #114
Labels
enhancement New feature or request
Projects

Comments

@mattfarina
Copy link
Collaborator

We need a method to filter the available charts based on annotations. This is useful to rancher so that rancher can have one repository and different versions of charts that work with different versions of rancher.

There are a few ways we could go about this. When this ticket is taken there can be further discussion.

  1. An annotation whose value is a semver. Note, this would not be tied to the hypper version but a version that could be passed into hypper
  2. The go API providing a method to filter repositories based on metadata in charts
  3. Some combination of the two that provides a means to do advanced filtering via the cli (semver aware) but not specific to rancher

We want to make this feature something in the API (like a filtering callback function) and possibly something exposed to the CLI that rancher can use but it's not rancher specific.

@mattfarina mattfarina added this to To do in Shit It via automation Mar 16, 2021
@Itxaka Itxaka moved this from To do to In progress in Shit It Apr 9, 2021
@Itxaka Itxaka self-assigned this Apr 9, 2021
@Itxaka Itxaka moved this from In progress to Blocked in Shit It Apr 9, 2021
@Itxaka Itxaka linked a pull request Apr 9, 2021 that will close this issue
@Itxaka
Copy link
Contributor

Itxaka commented Apr 9, 2021

blocked by #113

@Itxaka Itxaka added the enhancement New feature or request label Apr 9, 2021
@mattfarina
Copy link
Collaborator Author

@Itxaka how does search block this? Can search accept the same information and use that as part of its filtering? I realize this would deviate from upstream Helm.

@Itxaka
Copy link
Contributor

Itxaka commented Apr 13, 2021

@Itxaka how does search block this? Can search accept the same information and use that as part of its filtering? I realize this would deviate from upstream Helm.

Well, this build on top of the search command and as long as we dont have the search implemented on hypper we cannot implement this.

So more like adding the search command to hypper is blocking this :D

@Itxaka
Copy link
Contributor

Itxaka commented Apr 13, 2021

@mattfarina I just noticed that I didnt had you on the PR that tackled this, so probably you only saw my comment in this issue, sorry about that :D

@mattfarina
Copy link
Collaborator Author

#114 Implements part of it.

Still needed is the ability to handle version ranges and an API based method

Shit It automation moved this from Blocked to Done Apr 23, 2021
@mattfarina mattfarina reopened this Apr 23, 2021
Shit It automation moved this from Done to To do Apr 23, 2021
@viccuad
Copy link
Member

viccuad commented May 3, 2021

@mattfarina I'm having trouble parsing point 1 from the card. Is it correct, that the intent is to have an API method to filter charts based on a semver parameter? And preferably do that with an API method that accepts filters as callback functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Shit It
To do
Development

Successfully merging a pull request may close this issue.

3 participants